Question

I have this code but when there's 0 pennies, it doesn't output "and 0 pennies" at all, it is just left blank.

package edu.wit.cs.comp1050;

/**
* Solution to the third programming assignment
* When it runs it outputs the amount in quarters, dimes, nickels and pennies
*
* @author Rose Levine
*
*/
import java.util.Scanner;
public class PA1c {
  
   /**
   * Error message to display for negative amount
   */
   public static final String ERR_MSG = "Dollar amount must be non-negative!";
   public static int[] compute_coins(int coin_value ,int num, int amount_left){
       int[] arr=new int[2];
       if(!(coin_value> 0 && coin_value<100)){
           System.out.println("Coin value is invalid: ");
           return arr;
           }
       else{
           num = amount_left/coin_value;
           amount_left = amount_left%coin_value;
           arr[0]=num;
           arr[1]=amount_left;
           }
           return arr;
   }
   /**
   * Method to convert a double to
   * an integer
   *
   * @param num number to convert
   * @return converted value
   */
   public static int convertToInt(double num) {
       return (int) Math.round(num);
   }

   /**
   * Starts the program
   *
   * @param args command-lines, ignored
   */
   public static void main(String[] args) {
       int amount_left;
       int num, quarters, dimes, nickels, pennies;
       char c;
       double price;
       double money;
       num = 0;
       Scanner sc=new Scanner(System.in);
       System.out.print("Enter total amount: $");
       money=sc.nextDouble();
       if(money<0)
       System.out.println(ERR_MSG);
       else
       {
       money=money*100.0;
       double diff = money;
       amount_left = convertToInt(diff);
       int[] arr=new int[2];
       arr=compute_coins(25,num,amount_left);
       num=arr[0];
       amount_left=arr[1];

       System.out.print("You have ");
       if (num == 1) {
           System.out.print(num+" quarter, ");
       }
       else if (num > 1) {
       System.out.print(num+" quarters, ");
       }else{

           System.out.print("0 quarters, ");
       }
       if((amount_left>= 0)){

       arr=compute_coins(10,num,amount_left);

       num=arr[0];

       amount_left=arr[1];
       if (num == 1) {
       System.out.print(num+" dime, ");
       }
       else if (num > 1) {
           System.out.print(num+" dimes, ");
         
       }else{

       System.out.print("0 dimes, ");

       }

       if((amount_left>= 0)){

       arr=compute_coins(5,num,amount_left);

       num=arr[0];

       amount_left=arr[1];
       if (num == 1) {
           System.out.print(num+" nickel, and ");
       }
       else if (num > 1) {
       System.out.print(num+" nickels, and ");

       }else{

       System.out.print("0 nickels, and ");

       }

       if((amount_left>= 0)){

       arr=compute_coins(1,num,amount_left);

       num=arr[0];

       amount_left=arr[1];
         
       if (num == 1) {
               System.out.println(num+" penny.");
       }
       else if (num > 1)
       System.out.println(num+" pennies.");

       }else{

       System.out.println("0 pennies.");

       }
}
       }
       }
   }
}

Answer 1

The only thing to change is the closing curly brace of the last pennies block calculation (I have highlighted that brace in the code below). You probably had put it in the wrong place. Here's the right code, see the image of the code as well :

package edu.wit.cs.comp1050;

import java.util.Scanner;
public class PA1c
{
/*Error message to display for negative amount*/
public static final String ERR_MSG = "Dollar amount must be non-negative!";

public static int[] compute_coins(int coin_value ,int num, int amount_left)
{
int[] arr=new int[2];
if(!(coin_value> 0 && coin_value<100))
{
System.out.println("Coin value is invalid: ");
return arr;
}
else
{
num = amount_left/coin_value;
amount_left = amount_left%coin_value;
arr[0]=num;
arr[1]=amount_left;
}
return arr;
}
/*Method to convert a double to an integer, @param num number to convert, @return converted value */

public static int convertToInt(double num)
{
return (int) Math.round(num);
}
/* Starts the program, @param args command-lines, ignored */

public static void main(String[] args)
{
int amount_left;
int num, quarters, dimes, nickels, pennies;
char c;
double price;
double money;
num = 0;
Scanner sc=new Scanner(System.in);
System.out.print("Enter total amount: $");
money=sc.nextDouble();
if(money<0)
System.out.println(ERR_MSG);
else
{

money=money*100.0;
double diff = money;
amount_left = convertToInt(diff);
int[] arr=new int[2];
arr=compute_coins(25,num,amount_left);
num=arr[0];
amount_left=arr[1];

System.out.print("You have ");
if (num == 1)
{
System.out.print(num+" quarter, ");
}
else if (num > 1)
{
System.out.print(num+" quarters, ");
}
else
{
System.out.print("0 quarters, ");
}

if((amount_left>= 0))
{
arr=compute_coins(10,num,amount_left);
num=arr[0];
amount_left=arr[1];
if (num == 1)
{
System.out.print(num+" dime, ");
}
else if (num > 1)
{
System.out.print(num+" dimes, ");
}
else
{
System.out.print("0 dimes, ");
}

if((amount_left>= 0))
{
arr=compute_coins(5,num,amount_left);
num=arr[0];
amount_left=arr[1];
if (num == 1)
{
System.out.print(num+" nickel, and ");
}
else if (num > 1)
{
System.out.print(num+" nickels, and ");
}
else
{
System.out.print("0 nickels, and ");
}
if((amount_left>= 0))
{
arr=compute_coins(1,num,amount_left);
num=arr[0];
amount_left=arr[1];
if (num == 1)
{
System.out.println(num+" penny.");
}
else if (num > 1)
{
System.out.println(num+" pennies.");
}
else
{
System.out.println("0 pennies.");
}
} // this is that closing brace's right position.
}
}
}
}
}

Output: