Question

Having to repost this as the last answer wasn't functional. Please help

In the following program written in C++, I am having an issue that I cannot get the reducdedForm function in the Rational.cpp file to work. I cant figure out how to get this to work correctly, so the program will take what a user enters for fractions, and does the appropriate arithmetic to the two fractions and simplifies the answer.

Rational.h

class Rational {
private:
    int num;
    int denom;


public:
    int* Rational::reducedForm(int num, int denom);
    Rational(int =0, int=0);
    Rational add(const Rational &);//read as result = ("this"+  arg)
    Rational subtract(const Rational &); //read as result = ("this" -  arg)
    Rational multiply(const Rational &); //read as result = ("this" *  arg)
    Rational divide(const Rational &); //read as result  ("this" /  arg)
    void print();
    void printFloat();

};


#endif

Rational.cpp

#include "Rational.h"
#include <iostream>
#include <iomanip>

Rational::Rational(int anum, int adenom){
    int * reduced = reducedForm(anum, adenom);
    num = reduced[0];
    denom = reduced[1];
    delete reduced;  //delete the array that was on the heap (garbage collect)
}

int* Rational::reducedForm(int num, int denom){
    //first get the GCD for a and b
    int a = num, b = denom, c;
    int* ans = new int[2];          //array created on heap
    while ( a != 0 ) {
        c = a; a = b%a;  b = c;
    }
    //then reduce
    ans[0]= num/b;    //reduced numerator
    ans[1]= denom/b;  //reduced denominator
    return ans;
}


Rational Rational::add(const Rational & r2){//read as result = (this + arg)

    int numerator = (num * r2.denom) + (r2.num * denom);
    int denominator = denom * r2.denom;
    Rational sum(numerator, denominator);
    return sum;
}


Rational Rational::subtract(const Rational & r2){ //read as result = (this - arg)


    int numerator = (num * r2.denom) - (r2.num * denom);
    int denominator = denom * r2.denom;
    Rational sum(numerator, denominator);
    return sum;


}
Rational Rational::multiply(const Rational & r2){ //read as result = (this * arg)


    int numerator = (num * r2.num);
    int denominator = denom * r2.denom;
    Rational sum(numerator, denominator);
    return sum;
}

Rational Rational::divide(const Rational & r2){ //read as result  (this / arg)

    int numerator = num * r2.denom;
    int denominator = denom * r2.num;
    Rational sum(numerator, denominator);
    return sum;
}
void Rational::print(){

    std::cout<< num<<"/" << denom << std::endl;
}

void Rational::printFloat(){
    double f = (double) num/denom;
    std::cout<<std::fixed <<std::setprecision(3) << f << std::endl;
}

main.cpp

int main() {
    using namespace std;

    int numOne, denOne, numTwo, denTwo;

    cout<<"Please enter the first fraction's numerator and denominator"<<endl;
    cin>>numOne;
    cin>>denOne;
    Rational r1(numOne, denOne);
    r1.print();
    r1.printFloat();
    cout<<"============================="<<endl;

    cout<<"Pleae enter the second fraction's numerator and denominaytor"<<endl;
    cin>>numTwo;
    cin>>denTwo;
    Rational r2(numTwo,denTwo);
    r2.print();
    r2.printFloat();
    cout<<"============================="<<endl;


    cout<<"The addition is: "<<endl;
    Rational ans = r1.add(r2);
    ans.print();
    ans.printFloat();
    cout<<"============================="<<endl;


    cout<<"The subtraction is: "<<endl;
    ans=r1.subtract(r2);
    ans.print();
    ans.printFloat();
    cout<<"============================="<<endl;


    cout<<"The multiplication is: "<<endl;
    ans=r1.multiply(r2);
    ans.print();
    ans.printFloat();
    cout<< "============================="<<endl;


    cout <<"The division is: " <<endl;
    ans=r1.divide(r2);
    ans.print();
    ans.printFloat();
    cout<<"============================="<<endl;


    return 0;

}

Answer 1

The solution for the above question is given below with the screenshot of output.
---------------------------------------------------------------------------------------------------------------

I have kept the logic simple and output as per the question.

If there is anything else do let me know in comments

---------------------------------------------------------------------------------------------------------------

--------------- CODE TO COPY -----------------------------------------------------------------------

Rational.h

#ifndef _RATIONAL_H_
#define _RATIONAL_H_

class Rational {
  
private:
int num;
int denom;

public:

  
  
Rational(int =0, int=0);
  
int* reducedForm(int num, int denom);
  
Rational add(const Rational &);//read as result = ("this"+ arg)
Rational subtract(const Rational &); //read as result = ("this" - arg)
Rational multiply(const Rational &); //read as result = ("this" * arg)
Rational divide(const Rational &); //read as result ("this" / arg)
  
void print();
void printFloat();

};

#endif

Rational.cpp

#include "Rational.h"
#include <iostream>
#include <iomanip>

Rational::Rational(int anum, int adenom){
  
int * reduced = reducedForm(anum, adenom);
num = reduced[0];
denom = reduced[1];
delete reduced; //delete the array that was on the heap (garbage collect)
}

int* Rational::reducedForm(int num, int denom){
  
//first get the GCD for a and b
int a = num, b = denom, c;
int* ans = new int[2]; //array created on heap
  
while ( a != 0 ) {
  
c = a;
a = b%a;
b = c;
}
//then reduce
ans[0]= num/b; //reduced numerator
ans[1]= denom/b; //reduced denominator
return ans;
}

Rational Rational::add(const Rational & r2){//read as result = (this + arg)

int numerator = (num * r2.denom) + (r2.num * denom);
int denominator = denom * r2.denom;
Rational sum(numerator, denominator);
return sum;
}

Rational Rational::subtract(const Rational & r2){ //read as result = (this - arg)

int numerator = (num * r2.denom) - (r2.num * denom);
int denominator = denom * r2.denom;
Rational sum(numerator, denominator);
return sum;

}
Rational Rational::multiply(const Rational & r2){ //read as result = (this * arg)

int numerator = (num * r2.num);
int denominator = denom * r2.denom;
  
Rational sum(numerator, denominator);
  
return sum;
}

Rational Rational::divide(const Rational & r2){ //read as result (this / arg)

int numerator = num * r2.denom;
int denominator = denom * r2.num;
  
Rational sum(numerator, denominator);
  
return sum;
  
}

void Rational::print(){

std::cout<< num<<"/" << denom << std::endl;
}

void Rational::printFloat(){
  
double f = (double) num/denom;
std::cout<<std::fixed <<std::setprecision(3) << f << std::endl;
  
}

main.cpp

#include <iostream>
#include "Rational.h"
using namespace std;

int main() {
  
  
int numOne, denOne, numTwo, denTwo;

cout<<"Please enter the first fraction's numerator and denominator"<<endl;
cin>>numOne;
cin>>denOne;
Rational r1(numOne, denOne);
r1.print();
r1.printFloat();
cout<<"============================="<<endl;

cout<<"Pleae enter the second fraction's numerator and denominaytor"<<endl;
cin>>numTwo;
cin>>denTwo;
Rational r2(numTwo,denTwo);
r2.print();
r2.printFloat();
cout<<"============================="<<endl;

cout<<"The addition is: "<<endl;
Rational ans = r1.add(r2);
ans.print();
ans.printFloat();
cout<<"============================="<<endl;

cout<<"The subtraction is: "<<endl;
ans=r1.subtract(r2);
ans.print();
ans.printFloat();
cout<<"============================="<<endl;

cout<<"The multiplication is: "<<endl;
ans=r1.multiply(r2);
ans.print();
ans.printFloat();
cout<< "============================="<<endl;

cout <<"The division is: " <<endl;
ans=r1.divide(r2);
ans.print();
ans.printFloat();
cout<<"============================="<<endl;

return 0;
  
}

---------------------------------------------------------------------------------------------------------------

Output :

gcc version 4.6.3 Please enter the first fraction's numerator and denominator 4 8.500 Pleae enter the second fraction's numerator and denominaytor 6 63 2/21 0.095 The addition is: 25/42 0.595 The subtraction is: 17/42 0.405 The multiplication is: 0.048 The division is: 21/4 5.250