Question

Can someone help me solve this problem? Everything works but I keep getting an error "expression must have a constant value". Its the Extended Euclidean Algorithm

#include <iostream>
using namespace std;
#include<vector>

void TwoLargest(int a[], int x)
{
   int largeOne = a[0];
   int largeTwo = a[0];

   for (int i = 1; i < x; i++)
   {
       if (a[i] > largeOne)
       {
           largeTwo = largeOne;
           largeOne = a[i];
       }
       else if (largeTwo < a[i])
       {
           largeTwo = a[i];
       }
   }
   cout << "\nThe largest two numbers are: " << largeOne << " , " << largeTwo;

}

int main()
{
  
   vector<int> v;
   int x; //size of array or list

   cout << "\nList Size: ";
   cin >> x;

   int arr[x];//sets the array to the size user wants list to be

   cout << "\nNumbers in the list: ";
   for (int i = 0; i < x; i++)
   {
       cin >> arr[i];
   }
   TwoLargest(arr, sizeof(arr) / sizeof(arr[0]));

   system("pause");

   return 0;
}

Answer 1

I f you are using a variable to set size of array. then you must use dynamic array using


#include <iostream>

using namespace std;

#include<vector>


void TwoLargest(int a[], int x) {
    int largeOne = a[0];
    int largeTwo = a[0];

    for (int i = 1; i < x; i++) {
        if (a[i] > largeOne) {
            largeTwo = largeOne;
            largeOne = a[i];
        } else if (largeTwo < a[i]) {
            largeTwo = a[i];
        }
    }
    cout << "\nThe largest two numbers are: " << largeOne << " , " << largeTwo;

}

int main() {

    vector<int> v;
    int x; //size of array or list

    cout << "\nList Size: ";
    cin >> x;

    int *arr = new int[x];//sets the array to the size user wants list to be

    cout << "\nNumbers in the list: ";
    for (int i = 0; i < x; i++) {
        cin >> arr[i];
    }
    TwoLargest(arr, x);

    system("pause");

    return 0;
}