Question

why is this wrong for vectors

vector<char> decrypt{
{'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K',
'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U',
'V', 'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5',
'6', '7', '8', '9', 'A'},
{'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L',
'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V',
'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5', '6',
'7', '8', '9', 'A', 'B'},

};

for(int i = 0; i < 2); i++)
{
for(int j = 0; j < 35; j++)
{
cout << decrypt[i]{j} << endl;
}
cout << endl << endl;
}

Answer 1

   //error in declaration
   //you didn't followed the declaration syntax for 2d vector
   //you initializing with 2d values to a 1d char vector
   //for example
   /*vector<vector<int> > vect{ { 1, 2, 3 },
{ 4, 5, 6 },
{ 7, 8, 9 } }; *///is a 2d vector

   vector<char> decrypt{
{'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K',
'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U',
'V', 'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5',
'6', '7', '8', '9', 'A'},
{'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L',
'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V',
'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5', '6',
'7', '8', '9', 'A', 'B'},//error here coma , is not required heer

};

for(int i = 0; i < 2); i++)//error here ) is required
{
for(int j = 0; j < 35; j++)
{
cout << decrypt[i]{j} << endl;//error is here you have to use decrypt[i][j] to access values
}
cout << endl << endl;
}
  

//correct working code

#include<iostream>
#include<vector>
using namespace std;
int main()
{
   //corrected code
   vector<vector<char> > decrypt{
{'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K',
'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U',
'V', 'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5',
'6', '7', '8', '9', 'A'},
{'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L',
'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V',
'W', 'X', 'Y', 'Z', '1', '2', '3', '4', '5', '6',
'7', '8', '9', 'A', 'B'}
};

for(int i = 0; i < 2; i++)
{
for(int j = 0; j < 35; j++)
{
cout << decrypt[i][j] << endl;
}
cout << endl << endl;
}
  
   return 0;
}

//PLS give a thumbs up if you find this helpful, it helps me alot, thanks.