Question

I am trying to figure out why my C code is outputting "exited, segmentation fault". The game is supposed to generate 4 random numbers and store them in the "secret" array. Then the user is suppose to guess the secret code. The program also calculates the score of the user's guess. For now, I printed out the random secret code that has been generated, but when the game continues, it will output "exited, segmentation fault". Also, the GetSecretCode function has to be void and doesnt return anything. Help me out please.

#include <stdio.h>

#include <stdlib.h>

#include <string.h>

#include <time.h>

int *secret[5];

void GetSecretCode(int size, int my_array[])

{

srand(time(NULL));

for (size = 0; size < 4; size++)

{

my_array[size] = (rand() % 10) +0;

secret[4] = &my_array[size];

printf(" \nPasscode#%d generated:%d \n", size +1 , *secret[4] );

}

}

int getExactMatches(int *secret[], int guess[], int size)

{

int count = 0;

for (int i = 0; i < size; i++)

{

if (*secret[i] == guess[i])

count++;

}

return (count);

}

int getMatches(int *secret[], int guess[], int size)

{

int count = 0;

for (int i = 0; i < size; i++)

{

for (int j = 0; j < size; j++)

{

if (*secret[i] == guess[j])

count++;

}

}

return (count);

}

int game(int guess1[4], int* secret[4], int size)

{

size = 4;

int guessLimit = 6;

int guessCount = 0;

int outofGuess = 0;

int i = 0;

int score;

while (guess1[4] != *secret[4] && outofGuess == 0)

{

if (guessCount < guessLimit)

{

printf(" \n\n You have %d guesses...\n", guessLimit - i);

printf(" Guess the four digit secret code stored in the box:\n");

for (i = 0; i < size; i++)

{

printf(" \n %dst number : ", i + 1);

scanf("%d", guess1 + i);

}

guessCount++;

i = guessCount;

int getMatch1 = getMatches(secret, guess1, size) - getExactMatches(secret, guess1, size);

int getMatch2 = getExactMatches(secret, guess1, size);

printf("\n 〈Your score is: %d.%d 〉\n", getMatch2, getMatch1);

if (getMatch2 == 4 && getMatch1 == 0)

{

printf("\nCongratulations!, you guessed the code.\n");

return 0;

}

}

else

{

outofGuess = 1;

}

}

if (outofGuess == 1)

{

printf("\n 〈Sorry, you lost.〉\n");

return 0;

}

return 0;

}

int main()

{

char ch;

int size = 4;

int my_array1[8];

int guess1[5];

GetSecretCode(size, my_array1);

while (game(guess1,secret, size) == 0)

{

printf("\nDo you wish to continue? (y/n) ");

scanf(" %[^\n]%*c", & ch);

if (ch == 'y') {

game(guess1, secret, size);

}

if (ch == 'n')

{

printf("\n\nExiting... ");

exit(0);

} else if ((ch != 'y') || (ch != 'n'))

{

printf("Wrong letter entered, please try again.\n");

return 0;

}

return 0;

}

}

Answer 1

//i have corrected the code now it will work however i didnt change the logic of code as the exact scoring mechanism is provided.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <time.h>

int secret[4];
void GetSecretCode()
{
srand(time(NULL));
for(int size = 0; size < 4; size++)
{
secret[size] = (rand() % 10) +0;
printf(" \nPasscode#%d generated:%d \n", size +1 , secret[size]);
}
}

int getExactMatches(int secret[], int guess[], int size)
{

int count = 0;

for (int i = 0; i < size; i++)

{

if (secret[i] == guess[i])

count++;

}

return (count);

}

int getMatches(int secret[], int guess[], int size)

{

int count = 0;
int visited[4]={0};

for (int i = 0; i < size; i++)

{

for (int j = 0; j < size; j++)

{

if (secret[i] == guess[j]&&visited[j]!=1)
{
visited[j]=1;

count++;
}
}

}

return (count);

}

int game(int guess1[4], int secret[4], int size)

{

size = 4;

int guessLimit = 6;

int guessCount = 0;

int outofGuess = 0;

int i = 0;

int score;

while (outofGuess == 0)

{

if (guessCount < guessLimit)

{

printf(" \n\n You have %d guesses...\n", guessLimit - i);

printf(" Guess the four digit secret code stored in the box:\n");

for (i = 0; i < size; i++)

{

printf(" \n %dst number : ", i + 1);

scanf("%d", guess1+i);

}

guessCount++;

i = guessCount;

int getMatch1 = getMatches(secret, guess1, size) - getExactMatches(secret, guess1, size);

int getMatch2 = getExactMatches(secret, guess1, size);

printf("\n 〈Your score is: %d.%d 〉\n", getMatch2, getMatch1);

if (getMatch2 == 4 && getMatch1 == 0)

{

printf("\nCongratulations!, you guessed the code.\n");
outofGuess=1;

return 0;

}
else

{

outofGuess = 0;

}

}

}

if (outofGuess == 1)

{

printf("\n 〈Sorry, you lost.〉\n");

return 0;

}

return 0;

}

int main()

{

char ch;

int size = 4;

int my_array1[8];

int guess1[5];

GetSecretCode(size, my_array1);

while (game(guess1,secret, size) == 0)

{

printf("\nDo you wish to continue? (y/n) ");

scanf(" %[^\n]%*c", & ch);

if (ch == 'y') {

game(guess1, secret, size);

}

if (ch == 'n')

{

printf("\n\nExiting... ");

exit(0);

} else if ((ch != 'y') || (ch != 'n'))

{

printf("Wrong letter entered, please try again.\n");

return 0;

}

return 0;

}

}