Question

In c++ please

How do I get my printVector function to actually print the vector out? I was able to fill the vector with the text file of names, but I can't get it to print it out. Please help

#include <iostream>
#include <string>
#include <fstream>
#include <algorithm>
#include <vector>

using namespace std;

void openifile(string filename, ifstream &ifile){
  
ifile.open(filename.c_str(), ios::in);
  
if (!ifile){
cerr<<"Error opening input file " << filename << "... Exiting Program."<<endl;
exit(1);
}
  
}

void openofile(string filename, ofstream &ofile){
  
ofile.open(filename.c_str(), ios::out);
  
if (!ofile){
cerr<<"Error opening output file " << filename << "... Exiting Program."<<endl;
exit(1);
}
  
}

void fillVector(vector<string> vecName,int &dsize, ifstream &fin){
cout << "Starting to fill array" << endl;
int i =0;
string names;
while(!fin.eof()){
fin >> names;
vecName.push_back(names);
cout << vecName[i] << endl;
i++;
}
dsize = i;
}

void printVector(vector<string> vecName,int &dsize, ostream &out){
for(int i=0; i< vecName.size(); i++){
out << vecName[i] << " ";
}
out << endl;
}

int main(){
  
vector<string> vecName;
int dsize=0;
string iFilename = "words.txt";
string oFilename1 = "wordsoutput.txt";
string oFilename2 = "sortedWordsOutput.txt";
string oFilename3 = "uppercasewords.txt";
ifstream fin;
ofstream fout;
openifile(iFilename, fin);
fillVector(vecName, dsize,fin);
openofile(oFilename1, fout);
printVector(vecName,dsize,cout);
printVector(vecName,dsize,fout);
fout.close();

  
return 0;
}

Answer 1

#include <iostream>

#include <string>

#include <fstream>

#include <algorithm>

#include <vector>

using namespace std;

void openifile(string filename, ifstream &ifile){

ifile.open(filename.c_str(), ios::in);

if (!ifile){

cerr<<"Error opening input file " << filename << "... Exiting Program."<<endl;

exit(1);

}

}

void openofile(string filename, ofstream &ofile){

ofile.open(filename.c_str(), ios::out);

if (!ofile){

cerr<<"Error opening output file " << filename << "... Exiting Program."<<endl;

exit(1);

}

}

// we should take vector as refernce type than only

// we can point to the passed value otherwise it will create new vector and adds value to that vector

//instead of original vector

void fillVector(vector<string> &vecName,int &dsize, ifstream &fin){

cout << "Starting to fill array" << endl;

int i =0;

string names;

while(!fin.eof()){

fin >> names;

vecName.push_back(names);

cout << vecName[i] << endl;

i++;

}

dsize = i;

}

void printVector(vector<string> vecName,int &dsize, ostream &out){

for(int i=0; i< vecName.size(); i++){

out << vecName[i] << " ";

}

out << endl;

}

int main(){

vector<string> vecName;

int dsize=0;

string iFilename = "words.txt";

string oFilename1 = "wordsoutput.txt";

string oFilename2 = "sortedWordsOutput.txt";

string oFilename3 = "uppercasewords.txt";

ifstream fin;

ofstream fout;

openifile(iFilename, fin);

fillVector(vecName, dsize,fin);

openofile(oFilename1, fout);

printVector(vecName,dsize,cout);

printVector(vecName,dsize,fout);

fout.close();

return 0;

}

Answer 2

It seems like your code is almost correct. There is just a small issue in the printVector function. Instead of passing ostream &out, you should pass ofstream &out in the function signature to correctly print the vector to an output file.

Here's the corrected version of the printVector function:

cppCopy codevoid printVector(vector<string> vecName, int &dsize, ofstream &out) {    for (int i = 0; i < dsize; i++) {
        out << vecName[i] << " ";
    }
    out << endl;
}

In this updated function, we pass the ofstream &out instead of ostream &out, which allows us to correctly print the vector to an output file. With this change, the function will now work as expected to print the vector to the specified output file.

Your main function and other functions look good, and the program should now successfully print the vector to both the console and the wordsoutput.txt file.