Question

public void processCell(int rowIndex, int colIndex) {
       if (board[rowIndex][colIndex] != BoardCell.EMPTY) {
           for (int col = colIndex; col < getMaxCols(); col++) {
               if (board[rowIndex][col] == board[rowIndex][colIndex]){
                   board[rowIndex][col] = BoardCell.EMPTY;
                   score++;
               }
           }
           for (int col = colIndex; col > 0; col--) {
               if (board[rowIndex][col] == board[rowIndex][colIndex]) {
                   board[rowIndex][col] = BoardCell.EMPTY;
                   score++;
               }
           }
           for (int row = rowIndex; row < getMaxRows(); row++) {
               if (board[row][colIndex] == board[rowIndex][colIndex]) {
                   board[row][colIndex] = BoardCell.EMPTY;
                   score++;
               }
           }
           for (int row = rowIndex; row > 0; row--) {
               if (board[row][colIndex] == board[rowIndex][colIndex]) {
                   board[row][colIndex] = BoardCell.EMPTY;
                   score++;
               }
           }
       }

This is a game where I click on a point (board[rowindex][colindex] ) and the horizontal, vertical, and diagonal points with the same color are going to be empty. but my for loop is not working, every time when I click on a point, only that single point is empty. I'm not sure why.

Answer 1

At looking code it is not clear that what matrix you are taking. Is it a Global matrix ? if not then we have to pass it in function.

what is score variable and why you are taking it ?

Anyways I have reviewed the code and find some missing point which I have added.We have to add some validation for corner cases here. diagonal case is missing in the code.

Find the modified code below,

public void processCell(int rowIndex, int colIndex) {
// First make check for valid indexes
if(rowIndex >= 0 && rowIndex < getMaxRows() && colIndex >=0 && colIndex < getMaxCols() ){ // I am assuming getMaxRows(),getMaxCols will return correct values
if (board[rowIndex][colIndex] != BoardCell.EMPTY) {
   //setting same column to empty
for (int col = colIndex; col < getMaxCols(); col++) {
if (board[rowIndex][col] == board[rowIndex][colIndex]){
board[rowIndex][col] = BoardCell.EMPTY;
score++;
}
}
for (int col = colIndex; col >= 0; col--) { // here we have to include 0 also
if (board[rowIndex][col] == board[rowIndex][colIndex]) {
board[rowIndex][col] = BoardCell.EMPTY;
score++;
}
}
       //setting same row values to empty
for (int row = rowIndex; row < getMaxRows(); row++) {
if (board[row][colIndex] == board[rowIndex][colIndex]) {
board[row][colIndex] = BoardCell.EMPTY;
score++;
}
}
for (int row = rowIndex; row >= 0; row--) { // here we have to include 0 also
if (board[row][colIndex] == board[rowIndex][colIndex]) {
board[row][colIndex] = BoardCell.EMPTY;
score++;
}
}
       //setting diagonal values to EMPTY
       int col=colIndex;
       int row=rowIndex;
       while(col < getMaxCols() && row < getMaxRows()){
           if (board[row][col] == board[rowIndex][colIndex]){
board[row][col] = BoardCell.EMPTY;
score++;
}
           col++;
           row++;
       }
         
       col=colIndex;
       row=rowIndex;
       while(col >= 0 && row > 0){
           if (board[row][col] == board[rowIndex][colIndex]){
board[row][col] = BoardCell.EMPTY;
score++;
}
           col--;
           row--;
       }
}
     
     
   }
}