Question

Hi I got error C2660 : 'valuein' : function does not take 2 parameters in visual studio 2013

this is my code so far

#include <cstdlib>
#include <list>
#include <iostream>

using namespace std;
struct node
{
   int data;
   node* next;

};

void initialize(node*p);
void insert(int data,int n);
void remove(int b,int pos);
bool empty(node*);
void length();
bool valuein(int c);
int reportvalue(int value);
void ptintlist();
int menu();

int main()
{

   struct node*head=NULL;
   char commands;
   int value;
   int pos = 0;

   cout << "This program responds to commands the user enters to\nmanipulate an ordered list of integers, which is\ninitially empty. In the following commands, k1 is a\nposition in the list, and v is an integer." << endl;
   cout << "e -- Re-initialize the list to be empty.\ni v -- Insert the value v into the list.\nr v -- Remove the value v from the list.\nm -- Is the list empty ? \nl -- Report the length of the list.\np v -- Is the value v present in the list ? \nk k1 -- Report the k1th value in the list.\nw -- Write out the list.\nh -- See this menu.\nq -- Quit." << endl;
   cout << "-->";
  
   cin >> commands;

   do
   {

       switch (commands)
       {
       case 'e':
           initialize(head->next);
       case 'i':
       {cin >> value;
       insert(value, pos);
       pos++;
       }
       case 'r':
       { cin >> value;

       }
       case'k':
       { cin >> value;
      
       if (valuein(head, value) == true)
       {
           cout << "it is" << endl;
       }

       }

       }

       system("pause");
       return 0;
   } while (commands != 'q');
}
bool empty(node*)
{
   node *root;
   if (root->next == NULL)
       return true;
   else
       return false;
}

   void initialize(node*p)
{
  
   node *temp;
   if (p == NULL){
       return;
   }
   temp = p;
   initialize(p->next);
   delete temp;
}
   void insert(int data, int pos)
   {
       node*head = new node;
       node* prev = new node();
       node* curr = new node();
       node* newNode = new node();
       newNode->data = data;

       int tempPos = 0; // Traverses through the list

       curr = head; // Initialize current to head;
       if (head != NULL)
       {
           while (curr->next != NULL && tempPos != pos)
           {
               prev = curr;
               curr = curr->next;
               tempPos++;
           }

       }
   }
   bool valuein(node*head, int x)
   {
       bool judge=false;
       struct node* current = head; // Initialize current
       while (current != NULL)
       {
           if (current->data == x)
               judge=true;
           current = current->next;
       }
       return judge;
   }
The code is not finished yet.. If you find other mistake I made please let me know. Thank you!

Answer 1

#include <cstdlib>
#include <list>
#include <iostream>

using namespace std;
struct node {
    int data;
    node *next;

};

void initialize(node *p);

void insert(int data, int n);

void remove(int b, int pos);

bool empty(node *);

void length();

bool valuein(node *head, int x);

int reportvalue(int value);

void ptintlist();

int menu();

int main() {

    struct node *head = NULL;
    char commands;
    int value;
    int pos = 0;

    cout
            << "This program responds to commands the user enters to
manipulate an ordered list of integers, which is
initially empty. In the following commands, k1 is a
position in the list, and v is an integer."
            << endl;
    cout
            << "e -- Re-initialize the list to be empty.
i v -- Insert the value v into the list.
r v -- Remove the value v from the list.
m -- Is the list empty ? 
l -- Report the length of the list.
p v -- Is the value v present in the list ? 
k k1 -- Report the k1th value in the list.
w -- Write out the list.
h -- See this menu.
q -- Quit."
            << endl;
    cout << "-->";

    cin >> commands;


    do {


        switch (commands) {
            case 'e':
                initialize(head->next);
            case 'i': {
                cin >> value;
                insert(value, pos);
                pos++;
            }
            case 'r': {
                cin >> value;

            }
            case 'k': {
                cin >> value;

                if (valuein(head, value) == true) {
                    cout << "it is" << endl;
                }

            }

        }

        system("pause");
        return 0;
    } while (commands != 'q');
}

bool empty(node *) {
    node *root;
    if (root->next == NULL)
        return true;
    else
        return false;
}


void initialize(node *p) {

    node *temp;
    if (p == NULL) {
        return;
    }
    temp = p;
    initialize(p->next);
    delete temp;
}

void insert(int data, int pos) {
    node *head = new node;
    node *prev = new node();
    node *curr = new node();
    node *newNode = new node();
    newNode->data = data;

    int tempPos = 0; // Traverses through the list

    curr = head; // Initialize current to head;
    if (head != NULL) {
        while (curr->next != NULL && tempPos != pos) {
            prev = curr;
            curr = curr->next;
            tempPos++;
        }

    }
}

bool valuein(node *head, int x) {
    bool judge = false;
    struct node *current = head; // Initialize current
    while (current != NULL) {
        if (current->data == x)
            judge = true;
        current = current->next;
    }
    return judge;
}