Question

I'm trying to implement a rest() method for my GameCharacter where if a random number between 0-2 is generated then one or the other character rests and gains back about 5 to 10 health points. I don't know if I'm on the right track.

Here's my code so far and the rest() method is located at the bottom:

import java.util.Objects;
import java.util.Random;

/**
 * this class represents a class for role playing game.
 */
public class GameCharacter {

    private String mName;
    private int mLevel;
    private int mHealthPoints;
    private int mMagic;
    private int mGold;

    /**
     * Constructor that creates a new character given its name.
     * @param name The name of the character.
     */
    public GameCharacter(String name) {
        this(name, 1);
    }

    /**
     *
     * @param name
     * @param level
     */
    public GameCharacter(String name, int level) {
        mName = name;
        mLevel = level;
        mHealthPoints = 100 * mLevel;
        mMagic = 100 * mLevel;
        mGold = 100 * mLevel;
    }

    /**
     *
     * @return
     */
    public String getName() {

        return mName;
    }

    /**
     *
     * @return
     */
    public int getLevel() {

        return mLevel;
    }

    /**
     *
     * @return
     */
    public int getHealthPoints() {

        return mHealthPoints;
    }

    /**
     *
     * @return
     */
    public int getMagic() {

        return mMagic;
    }

    /**
     *
     * @return
     */
    public int getGold() {

        return mGold;
    }

    /**
     *
     * @param name
     */
    public void setName(String name) {

        mName = name;
    }

    /**
     *
     * @param o
     * @return
     */
    @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;
        GameCharacter that = (GameCharacter) o;
        return mLevel == that.mLevel &&
                mHealthPoints == that.mHealthPoints &&
                mMagic == that.mMagic &&
                mGold == that.mGold &&
                mName.equals(that.mName);
    }

    /**
     *
     * @return
     */
    @Override
    public int hashCode() {

        return Objects.hash(mName, mLevel, mHealthPoints, mMagic, mGold);
    }

    /**
     *
     * @return
     */
    @Override
    public String toString() {
        return "GameCharacter{" +
                "Name ='" + mName + '\'' +
                ", Level = " + mLevel +
                ", Health Points = " + mHealthPoints +
                ", Magic = " + mMagic +
                ", Gold = " + mGold +
                '}';
    }

    /**
     *
     * @param other
     */
    public void attack(GameCharacter other) {

        //this = this character(attacking)
        //other = second character (one being attacked)

        //Generate a random number from 0 to 9
        Random rng= new Random();
        int roll = rng.nextInt(10);

        //Calculate damage = roll * level
        int damage = roll * this.mLevel;

        // other character receives the damage
        other.mHealthPoints -= damage;
        //if other character's health goes negative,
        //make it zero
        if(other.mHealthPoints < 0)
            other.mHealthPoints = 0;
    }

    /**
     *
     * @param other
     */
    public void assist(GameCharacter other) {

        Random rng = new Random();
        int roll = rng.nextInt(5);

        switch(roll) {

                case 0:
                    //other character receives health
                    //this character loses health
                    other.mHealthPoints += 5 * this.mLevel;
                    this.mHealthPoints -= 5 * this.mLevel;
                    break;

                case 1:
                    other.mMagic += 5 * this.mLevel;
                    this.mMagic -= 5 * this.mLevel;
                    break;

                case 2:
                    other.mGold += 5 * this.mLevel;
                    this.mGold -= 5 * this.mLevel;
                    break;

                case 3:
                    other.mLevel++;
                    other.mGold += 100;
                    other.mHealthPoints += 100;
                    other.mMagic += 100;
                    this.mLevel--;
                    this.mGold -= 100;
                    this.mHealthPoints -= 100;
                    this.mMagic -= 100;

                case 4:
                    other.mHealthPoints += 100 * mLevel;
                    this.mHealthPoints += 100 * mLevel;
                    break;
            }
        }

        public void rest(GameCharacter other) {

            Random rng = new Random();
            int roll = rng.nextInt(2);

            if (this.mHealthPoints == 100 * mLevel || other.mHealthPoints == 100 * mLevel)
                mHealthPoints = 100 * mLevel;

            else if (this.mHealthPoints < 100 * mLevel || other.mHealthPoints < 100 * mLevel)
                mHealthPoints += 5;
        }
    }

Answer 1

import java.util.Objects;

import java.util.Random;

/**

* this class represents a class for role playing game.

*/

public class GameCharacter {

      

    private String mName;

    private int mLevel;

    private int mHealthPoints;

    private int mMagic;

    private int mGold;

   

    /**

     * Constructor that creates a new character given its name.

     * @param name The name of the character.

     */

    public GameCharacter(String name) {

        this(name, 1);

    }

   

    /**

    *

    * @param name

    * @param level

    */

    public GameCharacter(String name, int level) {

       mName = name;

       mLevel = level;

       mHealthPoints = 100 * mLevel;

       mMagic = 100 * mLevel;

       mGold = 100 * mLevel;

    }

  

          /**

          *

          * @return

          */

       public String getName() {

      

             return mName;

       }

       /**

          *

          * @return

          */

       public int getLevel() {

            

             return mLevel;

       }

       /**

          *

          * @return

          */

       public int getHealthPoints() {

             return mHealthPoints;

       }

      

       /**

            *

            * @return

            */

           public int getMagic() {

               return mMagic;

           }

           /**

            *

            * @return

            */

           public int getGold() {

               return mGold;

           }

          

           /**

            *

            * @param name

            */

           public void setName(String name) {

               mName = name;

           }

           /**

            *

            * @param o

            * @return

            */

           @Override

           public boolean equals(Object o) {

               if (this == o) return true;

               if (o == null || getClass() != o.getClass()) return false;

               GameCharacter that = (GameCharacter) o;

               return mLevel == that.mLevel &&

                       mHealthPoints == that.mHealthPoints &&

                       mMagic == that.mMagic &&

                       mGold == that.mGold &&

                       mName.equals(that.mName);

           }

          

           /**

            *

            * @return

            */

           @Override

           public int hashCode() {

               return Objects.hash(mName, mLevel, mHealthPoints, mMagic, mGold);

           }

           /**

            *

            * @return

            */

           @Override

           public String toString() {

               return "GameCharacter{" +

                       "Name ='" + mName + '\'' +

                       ", Level = " + mLevel +

                       ", Health Points = " + mHealthPoints +

                       ", Magic = " + mMagic +

                       ", Gold = " + mGold +

                       '}';

           }

          

           /**

            *

            * @param other

            */

           public void attack(GameCharacter other) {

               //this = this character(attacking)

               //other = second character (one being attacked)

               //Generate a random number from 0 to 9

               Random rng= new Random();

               int roll = rng.nextInt(10);

               //Calculate damage = roll * level

               int damage = roll * this.mLevel;

               // other character receives the damage

               other.mHealthPoints -= damage;

               //if other character's health goes negative,

             //make it zero

               if(other.mHealthPoints < 0)

                   other.mHealthPoints = 0;

           }

          

           /**

            *

            * @param other

            */

           public void assist(GameCharacter other) {

               Random rng = new Random();

               int roll = rng.nextInt(5);

               switch(roll) {

                       case 0:

                           //other character receives health

                           //this character loses health

                           other.mHealthPoints += 5 * this.mLevel;

                           this.mHealthPoints -= 5 * this.mLevel;

                           break;

                       case 1:

                           other.mMagic += 5 * this.mLevel;

                           this.mMagic -= 5 * this.mLevel;

                           break;

                       case 2:

                           other.mGold += 5 * this.mLevel;

                           this.mGold -= 5 * this.mLevel;

                           break;

                       case 3:

                           other.mLevel++;

                           other.mGold += 100;

                           other.mHealthPoints += 100;

                           other.mMagic += 100;

                           this.mLevel--;

                           this.mGold -= 100;

                           this.mHealthPoints -= 100;

                           this.mMagic -= 100;

                       case 4:

                           other.mHealthPoints += 100 * mLevel;

                           this.mHealthPoints += 100 * mLevel;

                           break;

                   }

               }

          

           /**

            * method that generates a random integer, roll, between [0,2) denoting the player

            * and random integer, points, between [5,10] denoting the health points to be added

            * if roll = 0, this character rests and points are added to this character's health points

            * if roll = 1, other character rests and points are added to other character's health points

            * @param other

            */

           public void rest(GameCharacter other) {

            Random rng = new Random();

            int roll = rng.nextInt(2); // generates a random integer between [0,2)

            int points = rng.nextInt(6)+5; // generates points between [5,10]

           

            if(roll == 0) // if roll = 0, add points to this character's mHealthPoints i.e this character rests

            {

            mHealthPoints += points;

            }else // if roll = 1, add points to other character's mHealthPoints i.e other character rests

            other.mHealthPoints += points;

        }

}