Question

Help finding my errors in C++ please

Header file

#ifndef _FISH_SHOWER_H
#define _FISH_SHOWER_H

#include <iostream>
#include <string>

using namespace std;
//NOTE: Prototypes are correct, use as a guide
void WriteHeader();
void FillVectors(vector<string> &type, vector<int> &minGals, vector<int> &maxGallons);
void AskFishShowerTypes(vector<string> &type, int *pIndex);
void CalcPondVol(int *pGal);
bool ValidateFishShower(int index, int pondVol, vector<int> &minGals, vector<int> &maxGals, vector<int> &rec);
void WriteInfo(string showerType, int gallons);
void WriteInfo(string showerType, vector<string> &showerTypes, vector<int> &recommendations, int gallons);

#endif
Main file

#include "FishShower.h"

using namespace std;

int main()
{
   string type = "", goAgain;
   int gallons, index;
   bool bValid;

   vector<string> showerTypes;
   vector<int> minRange;
   vector<int> maxRange;
   vector<int> recommendations;

   FillVectors(showerTypes, minRange, maxRange);
  
   WriteHeader();

   do
   {      
       AskFishShowerTypes(showerTypes, &index);
       CalcPondVol(&gallons);
       bValid = ValidateFishShower(gallons, index, minRange, maxRange, recommendations);
       if(!bValid)
       {
           WriteInfo(showerTypes.at(index), gallons);
       }
       else
       {
           WriteInfo(showerTypes.at(index), showerTypes, recommendations, gallons);
       }

       cout << "\n\nWant to enter another? yes/no ";
       cin >> goAgain;
       cin.ignore();

       recommendations.clear();

   }while(goAgain = "yes");

   cout << "\n\nThanks for playing!\n" << endl;

   cin.get();
   return 0;
}
Functions file

void WriteHeader()
{
   cout << "Student Debugger Q5\n"
       << "\nThis program gathers info concerning the user's"
       << "\npond and choice of C++ Fish Showers."
       << "\nIt makes suggestions for a perfect Fish Shower."
       << "\n\nProgram: Fish Shower\n" << endl;
}

void FillVectors(vector<string> &types, vector<int> &minGals, vector<int> maxGallons)
{
   types.push_back("Shebunkin Sprayer");
   types.push_back("Koi Rain Head");
   types.push_back("Golden Orfie Wash");
   types.push_back("Goldfish Rain Storm");
   types.push_back("Comet Monsoon");

   minGals.push_back(200);
   minGals.push_back(300);
   minGals.push_back(400);
   minGals.push_back(900);
   minGals.push_back(5000);

   maxGallons.push_back(400);
   maxGallons.push_back(500);
   maxGallons.push_back(1000);
   maxGallons.push_back(5000);
   maxGallons.push_back(10000);
}

void AskFishShowerTypes(vector<string> &showerTypes, int *pIndex)
{
   cout << "\n\n Here are the five types of showers offered:";
   for (unsigned int i = 0; i < showerTypes.size(); ++i)
   {
       cout << "\n" << i + 1 << ". " << showerTypes.at(i);
   }

   cout << "\n\n Please enter the number of the shower you are interested in: ";
   cin >> *pIndex;  

   *pIndex = *pIndex - 1; //now zero-indexed
   cin.ignore();      
}

void CalcPondVol(int *pGallons)
{
   const double PI = 3.14159265;
   const double CUBIC_INCHES_PER_GALLON = 231.0;

   int num;  
   cout << "\n Now we'll estimate the volume of your pond. ";
   cout << "\n Is your pond 1) Circular or 2) Rectangular ? ";
   cin >> num;
   cin.ignore();

   double diameter, depth, length, width, gallons, cubicInchVol;

   cout << "\n How deep is your pond in inches: ";
   cin >> depth;
   cin.ignore();

   if(num == 1) //circular
   {
       cout << "\n Please enter the pond's diameter in inches: ";
       cin >> diameter;
       cin.ignore();

       double radius = diameter/2.0;
       //use cylinder formula for volume Pi*r*r*h
       cubicInchVol = PI * radius * radius *depth;
   }
   else if(num == 2) //rectangular
   {
       cout << "\n Please enter the pond's length and width in inches: ";
       cin >> length >> width;
       cin.ignore();

       //use box formula for volume length * width * depth
       cubicInchVol = length * width * depth;
   }
   else
   {
       cout << "\n You entered an invalid number. Please try again.";
   }

   gallons = cubicInchVol/CUBIC_INCHES_PER_GALLON;
   pGallons = static_cast<int>(ceil(gallons));  

}

bool ValidateFishShower(int index, int pondVol, vector<int> &minGals, vector<int> &maxGals, vector<int> &recommends)
{
   const int MIN_VOLUME = 200; //gallons
   const int MAX_VOLUME = 10000; //gallons

   //check that there is a Fish Shower that will work
   if(pondVol > MAX_VOLUME && pondVol < MIN_VOLUME)
   {
       return false;
   }
  
   //check if the pond valume is within the range of the selected FishShower
   else if(pondVol >= minGals.at(index) && pondVol <= maxGals.at(index))
   {
       return true;
   }

   else
   {
       //check the other ranges for a recommendation
       //check all of the ranges and fill another vector with matches
  
       for(int i = 0; i < 5; ++i)
       {
           if(i != index)
           {
               if(pondVol>= minGals.at(i) && pondVol <= maxGals.at(i))
               {
                   recommends.push_back(i);
               }
           }
       }
       return false;
   }
  
}

void WriteInfo(string showerType, int gallons)
{
   cout<<"\n\n Good choice! For a " << gallons << " gallon pond"
       <<"\n you selected a "<< showerType << " Fish Shower!";
}

void WriteInfo(string showerType, vector<string> &showerTypes, vector<int> &recommendations, int gallons)
{
   if(recommendations.empty())
   {
       cout<< "\n\n The size of your pond, "<<*gallons<<" gallons, is outside of the ranges for the Fish Showers.";
   }

   else
   {
       cout<<"\n\n Sorry, the "<< showerType << " is not appropriate for your "<< gallons << " gallon pond."
           <<"\n May we suggest:";
       for( unsigned int i = 0; i< recommendations.size(); ++i)
       {
           int index = recommendations.at(i);
           cout <<"\n "<< showerTypes.at(index);
       }
   }
}

Answer 1

/* FishShower.h */

#ifndef _FISH_SHOWER_H
#define _FISH_SHOWER_H

#include <iostream>
#include <string>
#include<vector> // error forget to add

using namespace std;
//NOTE: Prototypes are correct, use as a guide
void WriteHeader();
void FillVectors(vector<string> &type, vector<int> &minGals, vector<int> &maxGallons);
void AskFishShowerTypes(vector<string> &type, int *pIndex);
void CalcPondVol(int *pGal);
bool ValidateFishShower(int index, int pondVol, vector<int> &minGals, vector<int> &maxGals, vector<int> &rec);
void WriteInfo(string showerType, int gallons);
void WriteInfo(string showerType, vector<string> &showerTypes, vector<int> &recommendations, int gallons);

#endif

/* main.cpp */

#include "FishShower.h"
#include<math.h>
#include<vector>
using namespace std;

int main()
{
string type = "", goAgain;
int gallons, index;
bool bValid;

vector<string> showerTypes;
vector<int> minRange;
vector<int> maxRange;
vector<int> recommendations;

FillVectors(showerTypes, minRange, maxRange);
  
WriteHeader();

do
{
AskFishShowerTypes(showerTypes, &index);
CalcPondVol(&gallons);
bValid = ValidateFishShower(gallons, index, minRange, maxRange, recommendations);
if(!bValid)
{
WriteInfo(showerTypes.at(index), gallons);
}
else
{
WriteInfo(showerTypes.at(index), showerTypes, recommendations, gallons);
}

cout << "\n\nWant to enter another? yes/no ";
cin >> goAgain;
cin.ignore();

recommendations.clear();

}while(goAgain == "yes"); // error == instead of =

cout << "\n\nThanks for playing!\n" << endl;

cin.get();
return 0;
}
//Functions file error there were no comments earlier

void WriteHeader()
{
cout << "Student Debugger Q5\n"
<< "\nThis program gathers info concerning the user's"
<< "\npond and choice of C++ Fish Showers."
<< "\nIt makes suggestions for a perfect Fish Shower."
<< "\n\nProgram: Fish Shower\n" << endl;
}
// Error vector<int> &maxGallons & missing
void FillVectors(vector<string> &types, vector<int> &minGals, vector<int> &maxGallons)
{
types.push_back("Shebunkin Sprayer");
types.push_back("Koi Rain Head");
types.push_back("Golden Orfie Wash");
types.push_back("Goldfish Rain Storm");
types.push_back("Comet Monsoon");

minGals.push_back(200);
minGals.push_back(300);
minGals.push_back(400);
minGals.push_back(900);
minGals.push_back(5000);

maxGallons.push_back(400);
maxGallons.push_back(500);
maxGallons.push_back(1000);
maxGallons.push_back(5000);
maxGallons.push_back(10000);
}

void AskFishShowerTypes(vector<string> &showerTypes, int *pIndex)
{
cout << "\n\n Here are the five types of showers offered:";
for (unsigned int i = 0; i < showerTypes.size(); ++i)
{
cout << "\n" << i + 1 << ". " << showerTypes.at(i);
}

cout << "\n\n Please enter the number of the shower you are interested in: ";
cin >> *pIndex;

*pIndex = *pIndex - 1; //now zero-indexed
cin.ignore();
}

void CalcPondVol(int *pGallons)
{
const double PI = 3.14159265;
const double CUBIC_INCHES_PER_GALLON = 231.0;

int num;
cout << "\n Now we'll estimate the volume of your pond. ";
cout << "\n Is your pond 1) Circular or 2) Rectangular ? ";
cin >> num;
cin.ignore();

double diameter, depth, length, width, gallons, cubicInchVol;

cout << "\n How deep is your pond in inches: ";
cin >> depth;
cin.ignore();

if(num == 1) //circular
{
cout << "\n Please enter the pond's diameter in inches: ";
cin >> diameter;
cin.ignore();

double radius = diameter/2.0;
//use cylinder formula for volume Pi*r*r*h
cubicInchVol = PI * radius * radius *depth;
}
else if(num == 2) //rectangular
{
cout << "\n Please enter the pond's length and width in inches: ";
cin >> length >> width;
cin.ignore();

//use box formula for volume length * width * depth
cubicInchVol = length * width * depth;
}
else
{
cout << "\n You entered an invalid number. Please try again.";
}

gallons = cubicInchVol/CUBIC_INCHES_PER_GALLON;
*pGallons = static_cast<int>(ceil(gallons)); // *pgallons since pointer

}

bool ValidateFishShower(int index, int pondVol, vector<int> &minGals, vector<int> &maxGals, vector<int> &recommends)
{
const int MIN_VOLUME = 200; //gallons
const int MAX_VOLUME = 10000; //gallons

//check that there is a Fish Shower that will work
if(pondVol > MAX_VOLUME && pondVol < MIN_VOLUME)
{
return false;
}
  
//check if the pond valume is within the range of the selected FishShower
else if(pondVol >= minGals.at(index) && pondVol <= maxGals.at(index))
{
return true;
}

else
{
//check the other ranges for a recommendation
//check all of the ranges and fill another vector with matches
  
for(int i = 0; i < 5; ++i)
{
if(i != index)
{
if(pondVol>= minGals.at(i) && pondVol <= maxGals.at(i))
{
recommends.push_back(i);
}
}
}
return false;
}
  
}

void WriteInfo(string showerType, int gallons)
{
cout<<"\n\n Good choice! For a " << gallons << " gallon pond"
<<"\n you selected a "<< showerType << " Fish Shower!";
}

void WriteInfo(string showerType, vector<string> &showerTypes, vector<int> &recommendations, int gallons)
{
if(recommendations.empty())
{
cout<< "\n\n The size of your pond, "<<gallons<<" gallons, is outside of the ranges for the Fish Showers.";
}

else
{
cout<<"\n\n Sorry, the "<< showerType << " is not appropriate for your "<< gallons << " gallon pond."
<<"\n May we suggest:";
for( unsigned int i = 0; i< recommendations.size(); ++i)
{
int index = recommendations.at(i);
cout <<"\n "<< showerTypes.at(index);
}
}
}

/* OUTPUT */

Student Debugger Q5

This program gathers info concerning the user's
pond and choice of C++ Fish Showers.
It makes suggestions for a perfect Fish Shower.

Program: Fish Shower

Here are the five types of showers offered:
1. Shebunkin Sprayer
2. Koi Rain Head
3. Golden Orfie Wash
4. Goldfish Rain Storm
5. Comet Monsoon

Please enter the number of the shower you are interested in: 1

Now we'll estimate the volume of your pond.
Is your pond 1) Circular or 2) Rectangular ? 1

How deep is your pond in inches: 2

Please enter the pond's diameter in inches: 5

Good choice! For a 1 gallon pond
you selected a Shebunkin Sprayer Fish Shower!

Want to enter another? yes/no no

Thanks for playing!

/* PLEASE UPVOTE */