Question

1:Fix the problems with this class definition, do not change program functionality

#include <iostream>

using namespace std;

class Rainbow{
  private:
  static int numRainbows;

  string colors;

  public:
  Rainbow() { colors = "Red Orange Yellow Green Blue Violet"; numRainbows++; }
  Rainbow(string colors) ; colors(colors) { numRainbows++; }   

  void setColors(string colors) { this->colors = colors; }

  string getColors() { return colors; }

  int getCount() { return numRainbows; }   

  bool operator==(const Rainbow & lhs, const Rainbow& rhs)
  {
  return lhs.colors == rhs.colors;
  }
};

int Rainbow::numRainbows = 0;

int main()
{

  Rainbow basic;
  Rainbow dim("Red Orange Yellow");
  Rainbow full("Red Orange Yellow Green Blue Violet");   

  cout << "I can see " << Rainbow::getCount() << " rainbows in the sky" << endl;
cout << basic.getColors() << endl;
  cout << dim.getColors() << endl;
  cout << full.getColors() << endl;  

  if ( basic == full )
  {
  cout << "basic and full have same colors" << endl;
  }
  else
  {
  cout << "They differ" << endl;
  }

return 0;
}

Answer 1

Answer:

Three errors were there:

1) To initialise the colors string using parameterized constructor, semicolon was used instead of colon.

2) getCount() function should be called without any object, so it should be a static function.

3) While doing operator overloading for == operator, one object to be compared is the calling object and other is the passed object. So, only 1 argument is needed and the colors variable of the calling object can be directly accessed.

Here is the corrected code:

#include <iostream>

using namespace std;

class Rainbow{
private:
static int numRainbows;

string colors;

public:
Rainbow() { colors = "Red Orange Yellow Green Blue Violet"; numRainbows++; }
Rainbow(string colors) : colors(colors) { numRainbows++; }   

void setColors(string colors) { this->colors = colors; }

string getColors() { return colors; }

static int getCount() { return numRainbows; }   

bool operator==(const Rainbow& rhs)
{
return colors == rhs.colors;
}
};

int Rainbow::numRainbows = 0;

int main()
{

Rainbow basic;
Rainbow dim("Red Orange Yellow");
Rainbow full("Red Orange Yellow Green Blue Violet");   

cout << "I can see " << Rainbow::getCount() << " rainbows in the sky" << endl;
cout << basic.getColors() << endl;
cout << dim.getColors() << endl;
cout << full.getColors() << endl;

if ( basic == full )
{
cout << "basic and full have same colors" << endl;
}
else
{
cout << "They differ" << endl;
}

return 0;
}

Output:

PLEASE UPVOTE IF YOU FOUND THIS HELPFUL!