Question

Im writing a c++ program to translate a sentence to pig latin. But I keep getting an error where it only prints out the "ay" part. Not sure where I'm wrong here.

string piglatin(string);
string substr(string, int&);

int main () //begin main
{
string input;
cout<<"Enter a sentence to convert: ";
getline(cin, input);
cout<<"Converted to Pig Latin: "<<piglatin(input)<<endl<<endl;
//cout << "Search for another value? (Y/N)"; //to convert again
system("pause");
return 0;
}
string piglatin(string input) //piglatin function
{
int len,
counter = 0,
start = 0,
stop = 0;
string word =" ",
newstring =" ";
do
{
word = substr(input, start); //translate
start++;
newstring=newstring+word+" ";
}
while(start<input.length());
return newstring;
}
string substr(string s,int&n)
{
char word[50]="", suffix[2];
int i=0;
suffix[0]=s[n];
suffix[1]='\0';//NULL
n++;

while(s[n]!=' '&&s[n]!='\0') //while(s[n]!=' '&&s[n]!='\0')
{
word[i]=s[n];
n++;
i++;
}
strcpy(word,suffix); //add the suffix
strcpy(word,"ay");//add ay to it
return word;

Answer 1

The problem is in the function string substr():- Wrong usage of strcpy() method:

So let me explain what the strcpy() method does:
Suppose a code:
string s1 = "Hello",s2 = "World";
strcpy(s1,s2); //s1 is the target variable, s2 is the variable whose string will be copied to s1
cout<<s1<<endl;

Then here, the output will be:
World
So, the string s2 is copied to s1 and not added to s1.

What you want to achieve is that the string s2 gets added at the end of s1 in this case, and in your code in the string substr function. So instead of using strcpy(), you will have to use strcat() method.
Now, let me demonstrate to you the usage of strcat using the above example:
Suppose a code:
string s1 = "Hello ",s2 = "World";
strcat(s1,s2); //s1 is the target variable, s2 is the variable whose string will be added to s1
cout<<s1<<endl;

Here,the output will be:- Hello World
which is what you want in your code, so your revised code is as follows which works:

CODE:

#include<iostream>
#include<string.h>

using namespace std;

string piglatin(string s);
string substr(string a, int&n);

int main () //begin main
{
string input;
cout<<"Enter a sentence to convert: ";
getline(cin, input);
cout<<"Converted to Pig Latin: "<<piglatin(input)<<endl<<endl;
//cout << "Search for another value? (Y/N)"; //to convert again
system("pause");
return 0;
}
string piglatin(string input) //piglatin function
{
int len,
counter = 0,
start = 0,
stop = 0;
string word =" ",
newstring =" ";
do
{
word = substr(input, start); //translate
start++;
newstring=newstring+word+" ";
}
while(start<input.length());
return newstring;
}
string substr(string s,int&n)
{
char word[50]="", suffix[2];
int i=0;
suffix[0]=s[n];
suffix[1]='\0';//NULL
n++;

while(s[n]!=' '&&s[n]!='\0') //while(s[n]!=' '&&s[n]!='\0')
{
word[i]=s[n];
n++;
i++;
}
strcat(word,suffix); //add the suffix
strcat(word,"ay");//add ay to it
return word;
}
_________________________________________________________

CODE IMAGE FOR INDENTATION:

______________________________________________________________

OUTPUT:

___________________________________________________________

I hope I was able to solve your problem. If you have any doubts feel free to get it clarified in the comments section.
Thank You!