Question

I just started working on some code for a password creator. I was doing some testing and I keep getting this error:

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: 6
at java.base/java.lang.StringLatin1.charAt(StringLatin1.java:47)
at java.base/java.lang.String.charAt(String.java:693)
at PasswordCreater.check(PasswordCreater.java:56)
at Password.main(Password.java:23

In my code I am having the user create a password that is at least 6 characters long, but no more than 16. Also, include at least one lowercase letter, one uppercase letter, one number digit and one special character of !,@,#,$,%,&.

Here is my main method (still not completely done)

import java.util.*;
public class Password
{
   public static void main(String [] args)
   {
       Scanner keyboard = new Scanner(System.in);
       PasswordCreator thing = new PasswordCreator ();
       String password = "";
       boolean dragon = true;
       while(dragon)
       {   System.out.print("Would like to create your own password(1) or have one generated for you(2).Press 1 or 2 to choose: ");
           int option = keyboard.nextInt();
           if(option == 1)
           {
               boolean wolfDog = true;
               while(wolfDog)
               {  
                   wolfDog = false;
                   System.out.print("Please create a password that is atleast 6 characters long, but no more than 16. " +"\n"+
                   "Also, include at least one lowercase letter, one uppercase letter, one number digt, and one special character of " + "\n"+
                   "!,@,#,$,%,&,*: ");
                   password = keyboard.nextLine();
                   thing.check(password);
                   if(thing.check(password) == false)
                   {
                       System.out.println("You entered an invalid password, try again.");
                       wolfDog = true;
                   }
               }
              
           }
           break;
       }
   }
}

Then here is my PasswordCreator class (also not done)

import java.util.*;
public class PasswordCreator
{
   private ArrayList upperCase;
   private ArrayList lowerCase;
   private ArrayList number;
   private ArrayList special;
   public PasswordCreater()
   {
       upperCase = new ArrayList<> (26);
       for(int i = 0; i < 26; i++)
       {
           upperCase.add(String.valueOf((char)(65 + i)));
       }

       lowerCase = new ArrayList <> (26);
       for(int i = 0; i < 26; i++)
       {
           lowerCase.add(String.valueOf((char)(65 + i)));
       }
      
       number = new ArrayList <> (9);
       for (int i = 0; i < 9; i++)
       {
           number.add(i);
       }
       special = new ArrayList <> (7);
       special.add("!");
       special.add("@");
       special.add("#");
       special.add("$");
       special.add("%");
       special.add("&");
       special.add("*'");
   }      
   //verfies if password is a minimun of 6 character but nomore than 16.
   //make sure password passes restricted rules
   public Boolean check(String password)
   {
       boolean goodOrNot = true; //flag
       int z = 0; //control variable
       if(password.length() < 6 || password.length() > 16)
       {
           goodOrNot = false;
       }
       while(goodOrNot && z > 1 || z < 13 )
       {
           int i =0;
           for(; i < password.length(); i++);
           {
               //Checking for uppercase requirements
               for(int j = 0; j < upperCase.size() && !found; j++)
               {
                   if(!special.contains(Character.isUpperCase(password.charAt(i))))
                   {
                       goodOrNot = false;
                       z++;
                   }
               }
               //checking for lowercase requirements
               for(int j = 0; j < lowerCase.size() && !found; j++)
               {
                   if(!special.contains(Character.isLowerCase(password.charAt(i))))
                   {
                       goodOrNot = false;
                       z++;
                   }
               }

               //checking for special character requirements.
               for(int j = 0; j < special.size() && !found; j++)
               {
                   if(!special.contains(Character.isLetter(password.charAt(i))))
                   {
                       goodOrNot = false;
                       z++;
                   }
               }
              
               for(int j = 0; j < number.size() && !found; j++)
               {
                   if(!number.contains(Character.isDigit(password.charAt(i))))
                   {
                       goodOrNot = false;
                       z++;
                   }
               }
              
           }
       }
       return goodOrNot;
   }
}

      
  
  
      

Answer 1

import java.util.*;

public class Password

{

   public static void main(String [] args)

   {

   Scanner keyboard = new Scanner(System.in);

   PasswordCreator thing = new PasswordCreator ();

   String password = "";

   boolean dragon = true;

   while(dragon)

   { System.out.print("Would like to create your own password(1) or have one generated for you(2).Press 1 or 2 to choose: ");

   int option = keyboard.nextInt();

   if(option == 1)

   {

   boolean wolfDog = true;

   while(wolfDog)

   {

   wolfDog = false;

   System.out.print("Please create a password that is atleast 6 characters long, but no more than 16. " +"\n"+

   "Also, include at least one lowercase letter, one uppercase letter, one number digt, and one special character of " + "\n"+

   "!,@,#,$,%,&,*: ");

   keyboard.nextLine();

   password = keyboard.nextLine();

   thing.check(password);

   if(thing.check(password) == false)

   {

   System.out.println("You entered an invalid password, try again.");

   wolfDog = true;

   }

   }

  

   }

   break;

   }

   }

}

//Then here is my PasswordCreator class (also not done)

==============================================================================

import java.util.*;

public class PasswordCreator

{

   private ArrayList upperCase;

   private ArrayList lowerCase;

   private ArrayList number;

   private ArrayList special;

   public PasswordCreator()

   {

   upperCase = new ArrayList<> (26);

   for(int i = 0; i < 26; i++)

   {

   upperCase.add(String.valueOf((char)(65 + i)));

   }

   lowerCase = new ArrayList <> (26);

   for(int i = 0; i < 26; i++)

   {

   lowerCase.add(String.valueOf((char)(65 + i)));

   }

  

   number = new ArrayList <> (9);

   for (int i = 0; i < 9; i++)

   {

   number.add(i);

   }

   special = new ArrayList <> (7);

   special.add("!");

   special.add("@");

   special.add("#");

   special.add("$");

   special.add("%");

   special.add("&");

   special.add("*'");

   }

   //verfies if password is a minimun of 6 character but nomore than 16.

   //make sure password passes restricted rules

   public Boolean check(String password)

   {

   boolean goodOrNot = true; //flag

   int z = 0; //control variable

   if(password.length() < 6 || password.length() > 16)

   {

   goodOrNot = false;

   }

   while(goodOrNot && z > 1 || z < 13 )

   {

   for(int i = 0; i < password.length(); i++)

   {

   //Checking for uppercase requirements

   for(int j = 0; j < upperCase.size() ; j++)

   {

   if(!special.contains(Character.isUpperCase(password.charAt(i))))

   {

   goodOrNot = false;

   z++;

   }

   }

   //checking for lowercase requirements

   for(int j = 0; j < lowerCase.size() ; j++)

   {

   if(!special.contains(Character.isLowerCase(password.charAt(i))))

   {

   goodOrNot = false;

   z++;

   }

   }

   //checking for special character requirements.

   for(int j = 0; j < special.size(); j++)

   {

   if(!special.contains(Character.isLetter(password.charAt(i))))

   {

   goodOrNot = false;

   z++;

   }

   }

  

   for(int j = 0; j < number.size(); j++)

   {

   if(!number.contains(Character.isDigit(password.charAt(i))))

   {

   goodOrNot = false;

   z++;

   }

   }

  

   }

   }

   return goodOrNot;

   }

}

========================================================
See Output

3 import java.util.*; 4 public class Password 6 public static void main(String [] args) Scanner keyboard-new Scanner(System. in); PasswordCreator thingnew PasswordCreator O; String password"; boolean dragon-true; while(dragon) 10 12 13 System.out.print("Would like to create your own password(1) or have one generated for you(2).Press 1 or 2 to cho int option keyboard.nextIntO; if(option1) 15 boolean wolfDog-true; while(wolfDog) 17 18 19 20 21 wolfDog-false System.out.print("Please create a password that is atleast 6 characters long, but no more than 16" " +"、 "Also, include at least one lowercase letter, one uppercase letter, one number digt, and one special cho 23 24. 25 26 27 28 20 keyboard.nextLineO password-keyboard.nextLineO; thing.check(password); if(thing.check(password)false) Console 3 Password [Java Application] /Library/Java/JavaVirtualMachines/jdk1.8.0_202.jdk/Contents/Home/bin/java (31-Mar-2019, 8:08:16 PM) Would like to create your own password(1) or have one generated for you(2).Press 1 or 2 to choose: 1 Please create a password that is atleast 6 characters long, but no more than 16 Also, include at least one lowercase letter, one uppercase letter, one number digt, and one special character of !,e,#,$,%,&,*. Hello

Thanks, PLEASE COMMENT if there is any concern.