Question

My C++ program is not compiling. Please explain how you fixed with detailed inline comments. I am using Visual Studio 2017. It's a character count program that keeps and displays a count of all the upper, lower case and digits in a .txt file. The requirement is to use classes to implement it.

-----------------------------------------------------------------HEADER FILE - Text.h---------------------------------------------------------------------------------------------

/* Header file contains only the class declarations and method prototypes. Comple class definitions will be in the class file.*/
#ifndef TEXT_H
#define TEXT_H
#include <string.h>

class Text {
private:
   //string line; // Only primitive datatypes are allowed in a Header file. String class objects are not allowed in Header files.
   char ch;
   int upperCasecount, lowerCaseCount, digitCount;

public:
   //Default constructor that initializes all 3 counters to 0.
   Text();

   //Function that reads the argument file and updates the upperCasecount, lowerCaseCount, and digitCount variables during each iteration of the loop
   void updateCounters();
  
   //Function that displays the values stored in all 3 counters
   void displayCounters() const;

};
#endif // !TEXT_H

-------------------------------------------------------------------------------CLASS FILE - Text.cpp -----------------------------------------------------------------------------------------------------

#include<iostream>
#include <string>
#include <fstream>
#include "Text.h"

using namespace std;

class Text {
private:
   string line;
   char ch;
   int charCount;
   int upperCasecount, lowerCaseCount, digitCount;

public:
   //Default constructor that initializes all 4 counters to 0.
   Text()
   {
       charCount = 0;
       upperCasecount = 0;
       lowerCaseCount = 0;
       digitCount = 0;
   }

   //Setter Function that reads the argument file and updates the upperCasecount, lowerCaseCount, and digitCount variables during each iteration of the loop
   void updateCounters(string fname)
   {
       ifstream inputFile;
       inputFile.open(fname);

       if (!inputFile)
       {
           cout << "Error opening file. Make sure the spelling of the filename matches the spelling of the actual file." << endl;
           cout << "Or It may not exist where indicated" << endl;
           system("pause");
       }

       while (!inputFile.eof())
       {
           //Read each line of the file into a string variable called line
           getline(inputFile, line);
           //Get the total number of characters in the line variable using string.length() method and that count to the charCount variable
           charCount = charCount + line.length();

           //Now read each character of the line and store it in the ch variable
           inputFile >> ch;

           //if the character being read is upper case, lower case or a digit, then increment the corresponding counter variables
           if (isupper(ch))
               upperCasecount = upperCasecount + 1;
           if (islower(ch))
               lowerCaseCount = lowerCaseCount + 1;
           if (isdigit(ch))
               digitCount = digitCount + 1;
       }
       inputFile.close();
   }

   //Getter function that displays the values stored in all 3 counters
   void displayCounters() const
   {
       cout << "Total Character count: " << charCount << endl << endl;
       cout << "Uppercase characters: " << upperCasecount << endl;
       cout << "Lowercase characters: " << lowerCaseCount << endl;
       cout << "Digits: " << digitCount << endl << endl;
   }
};

------------------------------------------------------------------------------MAIN PROGRAM - Source.cpp ----------------------------------------------------------------------------------------------------

#include<iostream>
#include <string>
#include <fstream>
#include "Text.h"

using namespace std;

int main()
{
   //Create an object of the type Text
   Text textobj;

   //Call the setter function that counts all the upper case, lower case digit characters in the file
   textobj.updateCounters();

   //Call the Getter function that displays ll the upper case, lower case digit characters in the file
   textobj.displayCounters();

   system("pause");
   return 0;
}

----------------------------------------------------------------------------------COMPILE TIME ERRORS -------------------------------------------------------------------------

text.cpp(8): error C2011: 'Text': 'class' type redefinition

text.h(7): note: see declaration of 'Text'

-----------------------------------------------------------------------------------------------------------------------------------------------------------------------

Answer 1

The issue here was that the class Text was redefined in Text.cpp even though it was defined in Text.h.There was no need to define class Text in cpp file.

Other comments are provided inline with the code.

Text.h

----------------------------------

#ifndef TEXT_H
#define TEXT_H
#include <string.h>

class Text {
private:
   std::string line; // Only primitive datatypes are allowed in a Header file. String class objects are not allowed in Header files.
   char ch;
   int upperCasecount, lowerCaseCount, digitCount, charCount;

public:
   //Default constructor that initializes all 3 counters to 0.
   Text();

   //Function that reads the argument file and updates the upperCasecount, lowerCaseCount, and digitCount variables during each iteration of the loop
   void updateCounters(std::string fname);

   //Function that displays the values stored in all 3 counters
   void displayCounters() const;

};
#endif // !TEXT_H

--------------------------------------

Text.cpp

-----------------------------------------

#include<iostream>
#include <string>
#include <fstream>
#include "Text.h"

using namespace std;

//No need to define the class Text again as it is being already defined in the header file.

//Default constructor that initializes all 4 counters to 0.
Text::Text()
{
   charCount = 0;
   upperCasecount = 0;
   lowerCaseCount = 0;
   digitCount = 0;
}

//Setter Function that reads the argument file and updates the upperCasecount, lowerCaseCount, and digitCount variables //during each iteration of the loop

void Text::updateCounters(string fname)
{
   ifstream inputFile;
   inputFile.open(fname);

   if (!inputFile)
   {
       cout << "Error opening file. Make sure the spelling of the filename matches the spelling of the actual file." << endl;
       cout << "Or It may not exist where indicated" << endl;
       system("pause");
   }

   while (!inputFile.eof())
   {
       //Read each line of the file into a string variable called line
       getline(inputFile, line);
       //Get the total number of characters in the line variable using string.length() method and that count to the charCount variable
       charCount = charCount + line.length();

       //Now read each character of the line and store it in the ch variable
       //Earlier we were reading the character from file
       //inputFile >> ch which was wrong
       for (size_t i = 0; i < line.length(); i++)
       {
           ch = line[i];

           //if the character being read is upper case, lower case or a digit, then increment the corresponding counter variables
           if (isupper(ch))
               upperCasecount = upperCasecount + 1;
           if (islower(ch))
               lowerCaseCount = lowerCaseCount + 1;
           if (isdigit(ch))
               digitCount = digitCount + 1;
       }
   }
   inputFile.close();
}

//Getter function that displays the values stored in all 3 counters
void Text::displayCounters() const
{
   cout << "Total Character count: " << charCount << endl << endl;
   cout << "Uppercase characters: " << upperCasecount << endl;
   cout << "Lowercase characters: " << lowerCaseCount << endl;
   cout << "Digits: " << digitCount << endl << endl;
}

---------------------------------------

Source.cpp

---------------------------------------

#include <iostream>
#include <string>
#include <fstream>
#include "Text.h"

using namespace std;

int main()
{
   //Create an object of the type Text
   Text textobj;

   //Call the setter function that counts all the upper case, lower case digit characters in the file
   //File name given is input.txt which is present in the same folder as the cpp file.
   textobj.updateCounters("input.txt");

   //Call the Getter function that displays ll the upper case, lower case digit characters in the file
   textobj.displayCounters();

   system("pause");
   return 0;
}

OUTPUT:

Total Character count: 170 Uppercase characters: 15 Lowercase characters: 36 Digits: 45 Press any key to continue .. .