Question

Help due in a few hours I need to clean this up can you help me clean up this code to accomplish the same task but with fewer lines/ more elegantly.

Thank you!

My code for the function is below:

3 Check board validity Implement a function that checks whether a board is valiod The function should return 0 if the board parameter violates any of the Sudoku rules and 1 if the int is_valid_board(int board[91[9]); board is valid. You have to check four constraints: Each cell holds a number between 1-9 (for the filled cells) or 0 (for the blanks). No number is repeated in any row No number is repeated in any column No number is repeated in any box.

int is_valid_board(int board[9][9]) {

    int array[10];
    int array_box[10] = {0, 0, 0, 0, 0, 0, 0, 0, 0};
    int i, j, k, x, y; //rows=i, columns =j
    for (i=0; i<9; i++) {

//Reset test array
        for (x = 0; x < 10; x++) {
            array[x] = 0;
        }

//Checking for columns
        for (j=0; j<9; j++) {
            k = board[j][i];
            if (board[j][i] >= 0 && board[j][i]<= 9 && k != 0 && array[k]) { //ensuring values are between 1-9
                print_sudoku_board(board);
                return 0;
            }
            array[k]++;
        }

//Reset test array
        for (x = 0; x < 10; x++) {
            array[x] = 0;
        }

//Checking for columns
        for (j=0; j<9; j++) {
            k = board[i][j];
            if (board[i][j] >= 0 && board[j][i]<= 9 && k != 0 && array[k]) { //ensuring values are between 1-9
                print_sudoku_board(board);
                return 0;
            }
            array[k]++;
        }


    }

    for (i=0; i<3; i++) {
        for (j=0; j<3; j++) {
//Reseting array for box
            for (x = 0; x < 10; x++) {
                array_box[x] = 0;
            }

            for (x = i * 3; x < i * 3 + 3; x++) {
                for (y = j*3; y < j * 3 + 3; y++) {
                    k = board[x][y];
                    if (k != 0 && array_box[k]) {
                        print_sudoku_board(board);
                        return 0;
                    }
                    array_box[k]++;
                }
            }
        }
    }
    return 1;


}

Answer 1

/*Kindly refer below resolved Code */

int main() {

    int a[10][10],i,j,n,k,sum,sum1,sum2,sum3,x,l;

    printf("enter the size N of N*N sudoku\n");            /* Enter the size of sudoku matrix.*/

    scanf("%d",&n);

    printf("enter the entries of sudoku row wise \n");     /* Going to read sudoku matrix (NxN).*/

    for (i=1;i<=n;i++) {

        for (j=1;j<=n;j++) {

            scanf("%d",&a[i][j]);

        }

        printf("\n");

    }

    printf("---------------------------------\n\n\n\n");

    printf("the matrix you entered is \n");

    for (i=1;i<=n;i++) {

        for (j=1;j<=n;j++) {

            printf("%d",a[i][j]);

            printf("|");

        }

        printf("\n");

    }

    for (i=1;i<=n;i++) {

        for (k=i;k==i;k++) {

            sum=0;

            for (j=1;j<=n;j++) {

                sum = sum + a[i][j];

            }

            if(sum!=45)

                x=1;

        }

    }

    for (j=1;j<=n;j++) {

        for(k=j;k==j;k++) {

            sum=0;

            for (i=1;i<=n;i++) {

                sum = sum+a[i][j];

            }

            if (sum!=45)

                x=1;

        }

    }

    for (k=1;k<=3;k++) {

        l = (1+(k-1)*n/3);

        for (i=l;i<=k*n/3;i++) {

            for(j=1;j<=3;j++) {

                sum1 = sum1+a[i][j];

            }

            for (j=4;j<=6;j++) {

                sum2 = sum2+a[i][j];

            }

            for (j=7;j<=9;j++) {

                sum3 = sum3+a[i][j];

            }

        }

        if (sum1!=45||sum2!=45||sum3!=45)

            x=1;

    }

    if (x==1)

        printf("sudoku not correct \n");

    else

        printf("correct sudoku");

    return 0;

}

/*Output*/

enter the size N of N*N Sudoku 3 enter the entries of sudoku row wise 2 3 3 2 2 3 the matrix you entered is 112131 312111 112131 sudoku not correct