Question

Identify the errors in this C program (struct - calculating volume, area of cylinder). Explain.

#include <stdio.h>
#define PI 3.14

typedef struct cylinder{
   float r,h;
   float areacircle=2*PI*r;
   float areacylinder;
   float volumecylinder;
   areacylinder=2*PI*r*h+2*PI*r*r;
   volumecylinder=PI*r*r*h;
};

int main()
{
   float start,numcyls;
   printf("How many cylinders do you want? Enter a positive integer.\n");
   scanf("%f",&numcyls);
   if(numcyls<1||ceilf(numcyls)!=numcyls)
   while()
   {printf("The number you have entered is not a positive integer. Please try again.\n");
       printf("Remember, you have been asked to enter the number of cylinders you want.\n");
       printf("Hence, you can only enter a positive integer.\n");
       scanf("%f",&numcyls);
       if(numcyls>1&&ceilf(numcyls)==numcyls) break;
   }
   else
   {for(start=1;start<=numcyls;start++)
       {printf("Enter radius of cylinder\n");
           scanf("%f",&r);
           printf("Enter length of axis of cylinder\n");
           scanf("%f",&h);
           printf("The area of the circular cross-section is: \n",areacircle);
           printf("The surface area of the cylinder is: \n",areacylinder);
           printf("The volume of the circular cross-section is: \n",volumecylinder);
           return 0;
}

Answer 1

//Most of the erros are commented at their place, some main errors are trying to define area and volume inside struct which is //not possible in c and not creating struct and trying to call

//Missing math.h for ceil function, instead of ceilf, write ceil
#include <stdio.h>
#include<math.h>
#define PI 3.14

typedef struct cylinder{
float r,h;
}cylinder;

float areacircle(float r){
//area of circle is Pi*r*r instead of 2*Pi*r
return PI*r*r;
}

float areacylinder(float r,float h){
return 2*PI*r*h+2*PI*r*r;
}

float volumecylinder(float r,float h){
return PI*r*r*h;
}

int main()
{
float start,numcyls;
printf("How many cylinders do you want? Enter a positive integer.\n");
scanf("%f",&numcyls);
if(numcyls<1||ceil(numcyls)!=numcyls)
{
while(1)
{
printf("The number you have entered is not a positive integer. Please try again.\n");
printf("Remember, you have been asked to enter the number of cylinders you want.\n");
printf("Hence, you can only enter a positive integer.\n");
scanf("%f",&numcyls);
if(numcyls>1&&ceil(numcyls)==numcyls) break;
}
}
//change else part to checking for number of cylinders again
if(numcyls>1&&ceil(numcyls)==numcyls)
{
for(start=1;start<=numcyls;start++)
{
cylinder cylinde;
printf("Enter radius of cylinder %0.0f\n",start);
scanf("%f",&cylinde.r);
printf("Enter length of axis of cylinder %.0f\n",start);
scanf("%f",&cylinde.h);
printf("The area of the circular cross-section is: %f \n",areacircle(cylinde.r));
printf("The surface area of the cylinder is: %f \n",areacylinder(cylinde.r,cylinde.h));
printf("The volume of the circular cross-section is:%f \n",volumecylinder(cylinde.r,cylinde.h));
printf("--------------------------------------------------------------------------------------");
}
}
//placing return 0 outside loop so that it wont stop program
return 0;
}//missing paranthesis