Question

I need to do object oriented programming for c++. I had to make make a program where it would add,subtract,multiply,and divide fraction. I got that working, but it wont work for negative can anyone fix it and explain how they did it?

Source.cpp code:

#include "Fraction.h"
#include <iostream>
using namespace std;

int main()
{
  
   Fraction f1(-4, 6);
   Fraction f2(5, -9);

   Fraction sum = sum.add(f1, f2);
   sum.print(sum);
   Fraction diff = diff.subtract(f1, f2);
   diff.print(diff);
   Fraction prod = prod.multiply(f1, f2);
   prod.print(prod);
   Fraction quot = quot.divide(f1, f2);
   quot.print(quot);

   return 0;
}

Header Class code:

#include <iostream>
using namespace std;

#pragma once
#ifndef FRACTION_H
#define FRACTION_H

class Fraction
{
private:
   int num;
   int den;
public:
   Fraction();
   Fraction(int, int);
   void setN(int);
   int getN();
   void setD(int);
   int getD();
   Fraction add(Fraction, Fraction);
   Fraction subtract(Fraction, Fraction);
   Fraction multiply(Fraction, Fraction);
   Fraction divide(Fraction, Fraction);
   Fraction simplify(Fraction);
   void print(Fraction);
};

Fraction::Fraction()
{
   setN(1);
   setD(1);
}

Fraction::Fraction(int n, int d)
{
   setN(n);
   setD(d);
}

void Fraction::setN(int n)
{
   num = (n > 0 ? n : 1);
}

void Fraction::setD(int d)
{
   den = (d > 0 ? d : 1);
}

int Fraction::getN()
{
   return num;
}

int Fraction::getD()
{
   return den;
}

Fraction Fraction::add(Fraction f1, Fraction f2)
{
   Fraction temp;

   temp.num = f1.num * f2.den + f2.num * f1.den;
   temp.den = f1.den * f2.den;

   return temp;
}

Fraction Fraction::subtract(Fraction f1, Fraction f2)
{
   Fraction temp;

   temp.num = f1.num * f2.den - f2.num * f1.den;
   temp.den = f1.den * f2.den;

   return temp;
}

Fraction Fraction::multiply(Fraction f1, Fraction f2)
{
   Fraction temp;

   temp.num = f1.num * f2.num;
   temp.den = f1.den * f2.den;

   return temp;
}

Fraction Fraction::divide(Fraction f1, Fraction f2)
{
   Fraction temp;

   temp.num = f1.num * f2.den;
   temp.den = f1.den * f2.num;

   return temp;
}

Fraction Fraction::simplify(Fraction f1)
{
   Fraction temp;
   for (int x = f1.den; x >= 1; x--)
   {
       if (f1.num % x == 0 && f1.den % x == 0)
       {
           temp.num = f1.num / x;
           temp.den = f1.den / x;
           break;
       }
   }
   return temp;
}

void Fraction::print(Fraction f)
{
   Fraction simp = simplify(f);
   cout << simp.num << "/" << simp.den << endl;
}

#endif

Answer 1

Note:

The wrong output is due to the setters method and also due to simplyfy function.

I modified those functions.

Could you plz go through this code and let me know if u need any changes in this.Thank You
=================================

// Fraction.h

#include <iostream>
using namespace std;

#ifndef FRACTION_H
#define FRACTION_H

class Fraction
{
private:
int num;
int den;
public:
Fraction();
Fraction(int, int);
void setN(int);
int getN();
void setD(int);
int getD();
Fraction add(Fraction, Fraction);
Fraction subtract(Fraction, Fraction);
Fraction multiply(Fraction, Fraction);
Fraction divide(Fraction, Fraction);
Fraction simplify(Fraction);
void print(Fraction);
};
Fraction::Fraction()
{
setN(1);
setD(1);
}

Fraction::Fraction(int n, int d)
{
setN(n);
setD(d);
}

void Fraction::setN(int n)
{
num =n;
}

void Fraction::setD(int d)
{
den =d;
}

int Fraction::getN()
{
return num;
}

int Fraction::getD()
{
return den;
}

Fraction Fraction::add(Fraction f1, Fraction f2)
{
Fraction temp;

temp.num = f1.num * f2.den + f2.num * f1.den;
temp.den = f1.den * f2.den;

return temp;
}

Fraction Fraction::subtract(Fraction f1, Fraction f2)
{
Fraction temp;

temp.num = f1.num * f2.den - f2.num * f1.den;
temp.den = f1.den * f2.den;

return temp;
}

Fraction Fraction::multiply(Fraction f1, Fraction f2)
{
Fraction temp;

temp.num = f1.num * f2.num;
temp.den = f1.den * f2.den;

return temp;
}

Fraction Fraction::divide(Fraction f1, Fraction f2)
{
Fraction temp;

temp.num = f1.num * f2.den;
temp.den = f1.den * f2.num;

return temp;
}

Fraction Fraction::simplify(Fraction f1)
{
int n1, n2;
if(f1.num<0)   
n1 = -f1.num;
else
n1=f1.num;
  
if(f1.den<0)
n2 = -f1.den;
else
n2=f1.den;
  

int gcd=1;
  
for(int i = 1; i <= n1 && i <= n2; i++)
{
if(n1%i==0 && n2%i==0)
gcd = i;
}
  
Fraction f;
  

  
f.num = f1.num / gcd;
f.den = f1.den / gcd;

if(f.num<0 && f.den<0)
{
f.num*=-1;
f.den*=-1;
}
else if(f.den<0)
{
f.num*=-1;
f.den*=-1;
}
  
  
return f;

}

void Fraction::print(Fraction f)
{
Fraction simp = simplify(f);
cout << simp.num << "/" << simp.den ;
}

#endif

=================================

// main.h

#include "Fraction.h"
#include <iostream>
using namespace std;

int main()
{
  
Fraction f1(-4, 6);
Fraction f2(5, -9);

Fraction sum = sum.add(f1, f2);
f1.print(f1);
cout<<" + ";
f2.print(f2);
cout<<" = ";
sum.print(sum);
cout<<endl;
Fraction diff = diff.subtract(f1, f2);
f1.print(f1);
cout<<" - ";
f2.print(f2);
cout<<" = ";
diff.print(diff);
cout<<endl;

Fraction prod = prod.multiply(f1, f2);
f1.print(f1);
cout<<" + ";
f2.print(f2);
cout<<" = ";
prod.print(prod);
cout<<endl;

Fraction quot = quot.divide(f1, f2);
f1.print(f1);
cout<<" + ";
f2.print(f2);
cout<<" = ";
quot.print(quot);
cout<<endl;

return 0;
}

=============================

Output:

=====================Could you plz rate me well.Thank You