Question

Find a source code of a program or developed software system. You can select any source code in any programming language. Provide a brief description of the source code you chose and properly cite the source.
Find two code “bad smells” on the selected code, and then refactor the code with an appropriate refactoring method. You should specify the bad smells that you found and the refactoring method that used. You should provide the original code and the Refactored code.

Answer 1

 //Source code with code smell class Person { // code smell - Temporary Field public int getScore(int a, int b){ int score = a * b; if(score > 100){ return score * 0.95; } else { return score * 0.25; } } } // code smell - duplicate code class Customer extends Person { // calculate age public function getAge() { return date('Y') - date('Y', strtotime("2012-10-5")); } } class Vendor extends Person { // calculate age public function getAge() { return date('Y') - date('Y', strtotime("2012-10-5")); } }

Refactored code:

 // Refactored code class Person { // removed temporary variable public int getScore(int a, int b) { if(a * b > 100){ return a * b * 0.95; } else { return a * b * 0.25; } } // removed duplicate code and moved to parent class public function getAge() { return date('Y') - date('Y', strtotime("2000-11-25")); } } class Customer extends Person { } class Vendor extends Person { }

I have added my custom method for another code smell.

Two code smells found in code:

1. Temporary Field
2. Duplicated code

1. Temporary field :

There was temporary field score in getScore(int,int) method

2. Duplicated code:

There was duplicate code for getting age in Customer and Vendor class in getAge() method.

Refactoring method used:

1. Temporary field: removed temporary variable score and reaplced with expression
2. Duplicated code: We have two duplicated methods in different classes that extend the same class, we can move the method in the parent class and delete it from the other two subclasses.

Note : Source code is written in Java