Question

This is my code where i am having errors:

#include <iostream>

#include <string>

#include <ctime>

#include <cstdlib>

namespace Action

{

    enum Shape { ROCK, PAPER, SCISSORS, INVALID_SHAPE };

    Shape charToShape(char selection);

    bool validShape(char selection);

    string shapeToString(Shape object); <--------[ERROR ON THIS LINE]

    Shape winningShape(Shape shape1, Shape shape2);

}

string Action::shapeToString(Action::Shape object) [ERROR HERE ON THIS LINE]

{

    // Return the name of the shape.

    switch (object)

    {

    case Action::ROCK:

        return "Rock";

    case Action::PAPER:

        return "Paper";

    case Action::SCISSORS:

        return "Scissors";

    default:

        return "Unknown Type";

    }

}

GameOutcome determineGameOutcome(Action::Shape player, Action::Shape computer)

{

    Action::Shape winnerObject;

    GameOutcome winner;

    // Check for a tie

    if (player == computer)

    {

        winner = TIE;

        std::cout << "Both players selected " << shapeToString(player) << ".\n"; [ERROR HERE ON shapeToString}

    }

    else // See who won

    {

        winnerObject = winningShape(player, computer);

        //Output each player's choice

        std::cout << "The player selected " << shapeToString(player); [ERROR HERE ON shapeToString]

        std::cout << " and the computer selected " << shapeToString(computer) [ERROR HERE ON shapeToString]

            << ".\n";

        //Decide the winner

        if (player == winnerObject)

        {

            winner = WIN;

        }

        else if (computer == winnerObject)

        {

            winner = LOSS;

        }

    }

    return winner;

}

This is the compiler error message:

RockPaperScissors.cpp:19:2: error: 'string' does not name a type; did you mean 'stdin'?
string shapeToString(Shape object);
^~~~~~
stdin
RockPaperScissors.cpp:163:1: error: 'string' does not name a type; did you mean 'stdin'?
string Action::shapeToString(Action::Shape object)
^~~~~~
stdin
RockPaperScissors.cpp: In function 'GameOutcome determineGameOutcome(Action::Shape, Action::Shape)':
RockPaperScissors.cpp:213:44: error: 'shapeToString' was not declared in this scope
std::cout << "Both players selected " << shapeToString(player) << ".\n";
^~~~~~~~~~~~~
RockPaperScissors.cpp:220:42: error: 'shapeToString' was not declared in this scope
std::cout << "The player selected " << shapeToString(player);

Answer 1

Resolved the errors which you specified. Actually the reason is string is used as "std::string" but instead you have directly used as "string" due to which it showed error. So, you can use as "std::string" or you can mention "using namespace std" at beginning and then use as "string" then also no issue.

In the corrected one, I used "std::string" which is as follows :-

#include <iostream>
#include <string>
#include <ctime>
#include <cstdlib>

namespace Action

{

enum Shape { ROCK, PAPER, SCISSORS, INVALID_SHAPE };

Shape charToShape(char selection);

bool validShape(char selection);

std::string shapeToString(Shape object);// <--------[ERROR ON THIS LINE]

Shape winningShape(Shape shape1, Shape shape2);

}

std::string Action::shapeToString(Action::Shape object)

{

// Return the name of the shape.

switch (object)

{

case Action::ROCK:

return "Rock";

case Action::PAPER:

return "Paper";

case Action::SCISSORS:

return "Scissors";

default:

return "Unknown Type";

}

}

GameOutcome determineGameOutcome(Action::Shape player, Action::Shape computer)

{

Action::Shape winnerObject;

GameOutcome winner;

// Check for a tie

if (player == computer)

{

winner = TIE;

std::cout << "Both players selected " << shapeToString(player) << ".\n";

}

else // See who won

{

winnerObject = winningShape(player, computer);

//Output each player's choice

std::cout << "The player selected " << shapeToString(player);

std::cout << " and the computer selected " << shapeToString(computer) << ".\n";

//Decide the winner

if (player == winnerObject)

{

winner = WIN;

}

else if (computer == winnerObject)

{

winner = LOSS;

}

}

return winner;

}