Question

I'm having trouble getting my program to print shapes

For example:

Which shape (L-line, T-triangle, R-rectangle): L
Enter an integer length between 1 and 25: 13
*************

Which shape (L-line, T-triangle, R-rectangle): t
Enter an integer base length between 3 and 25: 5
*
**
***
****
*****

Which shape (L-line, T-triangle, R-rectangle): r
Enter an integer width and height between 2 and 25: 4 5
****
****
****
****
****

Here's my code:

#include <stdio.h>

#include <ctype.h>

const int MAX_DIMENSION = 25;

void printLine(int length){

    scanf("%d", &length);

    for(int i=0; i<length; i++){

    if(length<0 && length>25){

        printf("That input is invalid.");

        else{

            printf("*");

        }

    }

}

}

void printTriangle(int baseLength){

scanf("%d", &baseLength);

for(int i=0; i<baselength; i++){

    if(length<3 && length>25){

        printf("That input is invalid.");

        else{

            printf("*");

        }

    }

}

}

void printRectangle(int width, int height){

scanf("%d %d", &width, &height);

for(int i=0; i<width; i++){

for(int j=0; j<height; j++){

    if((width<2 && width>25) && (height<2 && height>25){

        printf("That input is invalid.");

        else{

            printf("*");

        }

    }

}

}

}

int main() {

    

    char option;

    

    printf("Which shape (L-line, T-triangle, R-rectangle): ");

    scanf("%c", &option);

    option = toupper(option);

    printf("\n");

    switch (option) {

    case 'L' || case 'l':

    printf("Enter an Integer length between 1 and 25");

    printLine();

    break;  

    case 'T' || case 't':

    printf("Enter an Integer base length between 3 and 25");

    printTriangle();

        break;

    case 'R'|| case 'r':

    printf("Enter an Integer width and height between 2 and 25");

    printRectangle();

        break;

    default:

     break;

        }

        return 0;

}

Answer 1

Given, Asked to write a C refactor code which will print line, triangle and rectangle with char "*" with initial criteria for each using switch menu.

Code:

#include <stdio.h>
#include <ctype.h>
const int MAX_DIMENSION = 25;

void printLine()
{
int length;
scanf("%d", &length);
for(int i=0; i<length; i++)
{
if(length<0 || length>25)
{
printf("That input is invalid.");
break;
}
else
printf("*");
}
}

void printTriangle()
{
int baseLength;
printf("Enter an integer base length between 3 and 25: ");
scanf("%d",&baseLength);
if(baseLength<3 || baseLength>25)
{
printf("That input is invalid.\n");
}
else
{
for(int i=0; i<baseLength; i++)
{
for(int j=0;j<=i;j++)
{
printf("*");
}
printf("\n");
}
}
  
}

void printRectangle()
{
int width, height;
scanf("%d %d", &width, &height);
if((width<2 || width>25) || (height<2 || height>25))
{
printf("That input is invalid.\n");
}
else
{
for(int i=0; i<width; i++)
{
for(int j=0; j<height; j++)
{
printf("*");
}
printf("\n");
}
}
  
}

int main() {
char option;
printf("Which shape (L-line, T-triangle, R-rectangle): ");
scanf("%c", &option);
option = toupper(option);
printf("\n");
switch (option) {
case 'L':
printf("Enter an Integer length between 1 and 25: ");
printLine();
break;
  
case 'T':
printf("Enter an Integer base length between 3 and 25: ");
printTriangle();
break;
  
case 'R':
printf("Enter an Integer width and height between 2 and 25: ");
printRectangle();
break;
  
default:
break;
}
return 0;
}

Output:

Please let me know in the comments if you need more help in this.