Question

I'm writing code for a poker game and I'm not sure where I'm going wrong with it. My compiler is sending back errors for lines (typedef int bool)(the two char* declarations) and the two functions before my if else statement (approx lines 109).

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

#define SUITS 4
#define FACES 13
#define AVAILABLE 0
#define TAKEN 1
#define SIZE 5
#define TRUE 1
#define FALSE 0

void dealACard(char *suits[], char *faces[], int deck[][FACES]);
void dealAHand(char *suits[], char *faces[], int deck[][FACES]);
void analyzeHand(int suitsInHand[], int facesInHand[]);
void printResults(int suitsInHand[SUITS], int facesInHand[FACES], int *pointValue);

typedef int bool;
bool straight, flush, four, three;
int pairs; /* can be 0, 1, or 2 */

int main() {

char *suits[4] = {"Hearts", "Diamonds", "Spades", "Clubs"};
char *faces[13] = {"Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", "Jack", "Queen", "King", "Ace" };
int deck[4][13] = { AVAILABLE };
int i;
int suitsInHand[SUITS], facesInHand[FACES];

srand(time(NULL));

for(i = 0; i < 1; i++) {
printf("Player1 \n");
dealAHand(suits, faces, deck);
}
for(i = 1; i < 2; i++) {
printf("Player2 \n");
dealAHand(suits, faces, deck);
}
system("pause");
}

void dealAHand(char *suits[], char *faces[], int deck[][FACES]){
int i;
for(i = 0; i < 5; i++)
dealACard(suits, faces, deck);
printf("\n");

}

void dealACard(char *suits[], char *faces[], int deck[][FACES]){

int suitIndex, faceIndex;

suitIndex = rand() % 4;
faceIndex = rand() % 13;

while (deck[suitIndex][faceIndex] == TAKEN){
suitIndex = rand() % 4;
faceIndex = rand() % 13;
}

deck[suitIndex][faceIndex] = TAKEN;

printf("%s of %s \n", faces[faceIndex], suits[suitIndex]);

}

void analyzeHand(int suitsInHand[SUITS], int facesInHand[FACES]){

int num_consec = 0;
int rank, suit;

straight = FALSE;
flush = FALSE;
four = FALSE;
three = FALSE;
pairs = 0;

/* check for flush */
for (suit = 0; suit < SUITS; suit++)
if (suitsInHand[suit] == 5)
flush = TRUE;

/* check for straight */
rank = 0;
while (facesInHand[rank] == 0)
rank++;

for (rank = 0; rank < FACES && facesInHand[rank]; rank++)
num_consec++;

if (num_consec == 5) {
straight = TRUE;
return;
}

/* check for 4-of-a-kind, 3-of-a-kind, and pairs */
for (rank = 0; rank < FACES; rank++) {
if (facesInHand[rank] == 4)
four = TRUE;
if (facesInHand[rank] == 3)
three = TRUE;
if (facesInHand[rank] == 2)
pairs++;
}

void printResults(int suitsInHand[SUITS], int facesInHand[FACES], int *pointValue) {
void analyzeHand(suitsInHand, facesInHand);
if (straight && flush) {
printf("Straight flush\n\n");
*pointValue = 9;   
}

else if (four) {   
printf("Four of a kind\n\n");
*pointValue = 8;
}
else if (three && pairs == 1) {
printf("Full house\n\n");
*pointValue = 7;
}
else if (flush) {   
printf("Flush\n\n");
*pointValue = 6;
}
else if (straight) {
printf("Straight\n\n");
*pointValue = 5;
}
else if (three) {   
printf("Three of a kind\n\n");
*pointValue = 4;
}
else if (pairs == 2) {
printf("Two pairs\n\n");
*pointValue = 3;
}
else if (pairs == 1) {
printf("Pair\n\n");
*pointValue = 2;
points = *pointValue;
}
else{   
printf("High card\n\n");
*pointValue = 1;
points = *pointValue;
}
return points = *pointValue;
}

Answer 1

Note: Removed all the errors and now its compiling. I have highlighted the changed code and also commented the reason for error.

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

#define SUITS 4
#define FACES 13
#define AVAILABLE 0
#define TAKEN 1
#define SIZE 5
#define TRUE 1
#define FALSE 0

void dealACard(char *suits[], char *faces[], int deck[][FACES]);
void dealAHand(char *suits[], char *faces[], int deck[][FACES]);
void analyzeHand(int suitsInHand[], int facesInHand[]);
void printResults(int suitsInHand[SUITS], int facesInHand[FACES], int *pointValue);

typedef int boolean; //bool is a data type thats why throwing error so changed it to boolean
boolean straight, flush, four, three;
int pairs; /* can be 0, 1, or 2 */

int main() {

   char *suits[4] = {"Hearts", "Diamonds", "Spades", "Clubs"};
   char *faces[13] = {"Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", "Jack", "Queen", "King", "Ace" };
   int deck[4][13] = { AVAILABLE };
   int i;
   int suitsInHand[SUITS], facesInHand[FACES];

   srand(time(NULL));

   for(i = 0; i < 1; i++) {
       printf("Player1 \n");
       dealAHand(suits, faces, deck);
   }

   for(i = 1; i < 2; i++) {
       printf("Player2 \n");
       dealAHand(suits, faces, deck);
   }
  
   system("pause");
}

void dealAHand(char *suits[], char *faces[], int deck[][FACES]){
   int i;
   for(i = 0; i < 5; i++)
       dealACard(suits, faces, deck);
   printf("\n");

}

void dealACard(char *suits[], char *faces[], int deck[][FACES]){

   int suitIndex, faceIndex;

   suitIndex = rand() % 4;
   faceIndex = rand() % 13;

   while (deck[suitIndex][faceIndex] == TAKEN){
       suitIndex = rand() % 4;
       faceIndex = rand() % 13;
   }

   deck[suitIndex][faceIndex] = TAKEN;

   printf("%s of %s \n", faces[faceIndex], suits[suitIndex]);

}

void analyzeHand(int suitsInHand[SUITS], int facesInHand[FACES]){

   int num_consec = 0;
   int rank, suit;

   straight = FALSE;
   flush = FALSE;
   four = FALSE;
   three = FALSE;
   pairs = 0;

   /* check for flush */
   for (suit = 0; suit < SUITS; suit++)
       if (suitsInHand[suit] == 5)
           flush = TRUE;

   /* check for straight */
   rank = 0;
   while (facesInHand[rank] == 0)
       rank++;

   for (rank = 0; rank < FACES && facesInHand[rank]; rank++)
       num_consec++;

   if (num_consec == 5) {
       straight = TRUE;
       return;
   }

   /* check for 4-of-a-kind, 3-of-a-kind, and pairs */
   for (rank = 0; rank < FACES; rank++) {
       if(facesInHand[rank] == 4)
           four = TRUE;
       if(facesInHand[rank] == 3)
           three = TRUE;
       if(facesInHand[rank] == 2)
           pairs++;
   }
} //function was not closed

   void printResults(int suitsInHand[SUITS], int facesInHand[FACES], int *pointValue) {
       analyzeHand(suitsInHand, facesInHand); //void was extra so removed it
       if (straight && flush) {
           printf("Straight flush\n\n");
           *pointValue = 9;   
       }

       else if (four) {   
           printf("Four of a kind\n\n");
           *pointValue = 8;
       }
       else if (three && pairs == 1) {
           printf("Full house\n\n");
           *pointValue = 7;
       }
       else if (flush) {   
           printf("Flush\n\n");
           *pointValue = 6;
       }
       else if (straight) {
           printf("Straight\n\n");
           *pointValue = 5;
       }
       else if (three) {   
           printf("Three of a kind\n\n");
           *pointValue = 4;
       }
       else if (pairs == 2) {
           printf("Two pairs\n\n");
           *pointValue = 3;
       }
       else if (pairs == 1) {
           printf("Pair\n\n");
           *pointValue = 2;
           //points = *pointValue;
       }
       else{   
           printf("High card\n\n");
           *pointValue = 1;
           //points = *pointValue; //points was undeclared, also it is not needed as pointValue is a pointer
       }
       //return points = *pointValue; //cant return value in a void function
   }